From: Vitaliy Ivanov <vitalivanov@gmail.com>
To: Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
vitalivanov@gmail.com
Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix
Date: Thu, 07 Jul 2011 19:37:48 +0300 [thread overview]
Message-ID: <1310056668.3528.51.camel@vivanov> (raw)
>From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Thu, 7 Jul 2011 19:29:06 +0300
Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix
We should cleanup memory even though 'putenv' fails.
Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
---
arch/um/os-Linux/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c
index fb2a97a..67fe012 100644
--- a/arch/um/os-Linux/main.c
+++ b/arch/um/os-Linux/main.c
@@ -107,8 +107,8 @@ static void setup_env_path(void)
snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path);
if (putenv(new_path)) {
perror("couldn't putenv to set a new PATH");
- free(new_path);
}
+ free(new_path);
}
extern void scan_elf_aux( char **envp);
--
1.7.0.4
next reply other threads:[~2011-07-07 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 16:37 Vitaliy Ivanov [this message]
2011-07-07 16:48 ` [PATCH 3/3] uml: os-Linux/main.c memory leak fix Richard Weinberger
2011-07-08 10:16 ` Vitaliy Ivanov
2011-07-08 10:22 ` Richard Weinberger
2011-07-08 10:36 ` Vitaliy Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310056668.3528.51.camel@vivanov \
--to=vitalivanov@gmail.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox