From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Rafal Bilski <rafalbilski@interia.pl>,
Dave Jones <davej@redhat.com>,
cpufreq@vger.kernel.org
Subject: [RFC][PATCH] cpufreq: e_powersaver: Fix checking brand for EPS_BRAND_C3
Date: Fri, 08 Jul 2011 16:37:23 +0800 [thread overview]
Message-ID: <1310114243.2940.3.camel@phoenix> (raw)
Do not return -ENODEV for EPS_BRAND_C3.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
I just found the code is suspect.
I don't have this hardware handy.
Anyone can help to confirm and test if this patch works?
Axel
drivers/cpufreq/e_powersaver.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c
index 35a257d..637f055 100644
--- a/drivers/cpufreq/e_powersaver.c
+++ b/drivers/cpufreq/e_powersaver.c
@@ -199,8 +199,9 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
break;
case EPS_BRAND_C3:
printk(KERN_CONT "C3\n");
- return -ENODEV;
break;
+ default:
+ return -ENODEV;
}
/* Enable Enhanced PowerSaver */
rdmsrl(MSR_IA32_MISC_ENABLE, val);
--
1.7.4.1
next reply other threads:[~2011-07-08 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 8:37 Axel Lin [this message]
2011-07-11 16:36 ` [RFC][PATCH] cpufreq: e_powersaver: Fix checking brand for EPS_BRAND_C3 Rafał Bilski
2011-07-11 22:08 ` [PATCH] e_powersaver: Add sanity checks to code provided by VIA Rafał Bilski
2011-07-11 23:15 ` [PATCH] e_powersaver: Underclock checks Rafał Bilski
2011-07-11 23:25 ` Dave Jones
2011-07-12 17:00 ` Rafał Bilski
2011-07-13 16:40 ` Rafał Bilski
2011-07-13 16:45 ` Dave Jones
2011-07-13 22:24 ` [PATCH] e_powersaver: Add sanity checks to code provided by VIA Dave Jones
2011-07-13 23:01 ` Rafał Bilski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310114243.2940.3.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafalbilski@interia.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).