[PATCH 2/2] Staging: comedi: fix wraning:line over 80 character issue in rtd520.c

[PATCH 2/2] Staging: comedi: fix wraning:line over 80 character issue in rtd520.c

[ravishankar]

From: Ravishankar <ravi.shankar@greenturtles.in>

This is a patch to the rtd520.c file that fixes up a line over 80 charcter warning found by the checkpatch.pl tool

Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
 drivers/staging/comedi/drivers/rtd520.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
index 7f09ed7..44dbf43 100644
--- a/drivers/staging/comedi/drivers/rtd520.c
+++ b/drivers/staging/comedi/drivers/rtd520.c
@@ -1403,7 +1403,8 @@ static int ai_read_dregs(struct comedi_device *dev, struct comedi_subdevice *s)
 
 		d = d >> 3;	/* low 3 bits are marker lines */
 		if (CHAN_ARRAY_TEST(devpriv->chanBipolar, s->async->cur_chan))
-			sample = d + 2048;	/* convert to comedi unsigned data */
+			/* convert to comedi unsigned data */
+			sample = d + 2048;
 		else
 			sample = d;
 
@@ -1491,9 +1492,11 @@ static int ai_process_dma(struct comedi_device *dev, struct comedi_subdevice *s)
 		short sample;
 
 		if (CHAN_ARRAY_TEST(devpriv->chanBipolar, s->async->cur_chan)) {
-			sample = (*dp >> 3) + 2048;	/* convert to comedi unsigned data */
+			/* convert to comedi unsigned data */
+			sample = (*dp >> 3) + 2048;
 		else
-			sample = *dp >> 3;	/* low 3 bits are marker lines */
+			/* low 3 bits are marker lines */
+			sample = *dp >> 3;
 
 		*dp++ = sample;	/* put processed value back */
 
@@ -1543,7 +1546,8 @@ static irqreturn_t rtd_interrupt(int irq,	/* interrupt number (ignored) */
 	struct comedi_device *dev = d;	/* must be called "dev" for devpriv */
 	u16 status;
 	u16 fifoStatus;
-	struct comedi_subdevice *s = dev->subdevices + 0;	/* analog in subdevice */
+	/* analog in subdevice */
+	struct comedi_subdevice *s = dev->subdevices + 0;
 
 	if (!dev->attached)
 		return IRQ_NONE;
-- 
1.6.5.2

Re: [PATCH 2/2] Staging: comedi: fix wraning:line over 80 character issue in rtd520.c

[Greg KH]

On Fri, Jul 08, 2011 at 04:07:39PM +0530, ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
> 
> This is a patch to the rtd520.c file that fixes up a line over 80 charcter warning found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
>  drivers/staging/comedi/drivers/rtd520.c |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index 7f09ed7..44dbf43 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -1403,7 +1403,8 @@ static int ai_read_dregs(struct comedi_device *dev, struct comedi_subdevice *s)
>  
>  		d = d >> 3;	/* low 3 bits are marker lines */
>  		if (CHAN_ARRAY_TEST(devpriv->chanBipolar, s->async->cur_chan))
> -			sample = d + 2048;	/* convert to comedi unsigned data */
> +			/* convert to comedi unsigned data */
> +			sample = d + 2048;

While this will work, it's not a good idea.  Please put braces in here
if you are going to do this.

greg k-h