* [PATCH] dell-laptop - using buffer without mutex_lock
@ 2011-07-08 22:01 Jose Alonso
2011-07-09 21:28 ` Greg Dietsche
0 siblings, 1 reply; 2+ messages in thread
From: Jose Alonso @ 2011-07-08 22:01 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-kernel
Using buffer->output[1] without mutex_lock()
--- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG
2011-07-04 19:56:24.000000000 -0300
+++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c 2011-07-08
18:27:02.420791868 -0300
@@ -560,11 +560,11 @@
else
dell_send_request(buffer, 0, 1);
+ ret = buffer->output[1];
+
out:
release_buffer();
- if (ret)
- return ret;
- return buffer->output[1];
+ return ret;
}
static const struct backlight_ops dell_ops = {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dell-laptop - using buffer without mutex_lock
2011-07-08 22:01 [PATCH] dell-laptop - using buffer without mutex_lock Jose Alonso
@ 2011-07-09 21:28 ` Greg Dietsche
0 siblings, 0 replies; 2+ messages in thread
From: Greg Dietsche @ 2011-07-09 21:28 UTC (permalink / raw)
To: Jose Alonso; +Cc: Matthew Garrett, linux-kernel
Hi Jose,
On Fri, Jul 08, 2011 at 07:01:27PM -0300, Jose Alonso wrote:
> Using buffer->output[1] without mutex_lock()
>
> --- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG
> 2011-07-04 19:56:24.000000000 -0300
> +++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c 2011-07-08
> 18:27:02.420791868 -0300
> @@ -560,11 +560,11 @@
> else
> dell_send_request(buffer, 0, 1);
>
> + ret = buffer->output[1];
> +
> out:
> release_buffer();
> - if (ret)
> - return ret;
> - return buffer->output[1];
> + return ret;
> }
>
> static const struct backlight_ops dell_ops = {
>
>
> --
You should run this patch through scripts/checkpatch.pl as it
reports a few style issues for your patch including a missing
signed-off-by line and some spaces that should be converted to tabs.
Greg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-09 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-08 22:01 [PATCH] dell-laptop - using buffer without mutex_lock Jose Alonso
2011-07-09 21:28 ` Greg Dietsche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox