From: Mark Einon <mark.einon@gmail.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
o.hartmann@telovital.com, Mark Einon <mark.einon@gmail.com>
Subject: [PATCH 04/10] staging: et131x: Remove unecessary *etdev NULL check in et1310_phy_init()
Date: Sun, 10 Jul 2011 16:35:29 +0100 [thread overview]
Message-ID: <1310312135-28407-5-git-send-email-mark.einon@gmail.com> (raw)
In-Reply-To: <1310312135-28407-1-git-send-email-mark.einon@gmail.com>
It is impossible to get to this function with the pointer being NULL.
Tested on an ET-131x device.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
drivers/staging/et131x/et1310_phy.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et1310_phy.c b/drivers/staging/et131x/et1310_phy.c
index 72892e0..61ee744 100644
--- a/drivers/staging/et131x/et1310_phy.c
+++ b/drivers/staging/et131x/et1310_phy.c
@@ -908,9 +908,6 @@ void et1310_phy_init(struct et131x_adapter *etdev)
{
u16 data, index;
- if (etdev == NULL)
- return;
-
/* get the identity (again ?) */
et131x_mii_read(etdev, PHY_ID_1, &data);
et131x_mii_read(etdev, PHY_ID_2, &data);
--
1.7.4.4
next prev parent reply other threads:[~2011-07-10 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 15:35 [PATCH 0/10] staging: et131x: Kernel coding style cleanups Mark Einon
2011-07-10 15:35 ` [PATCH 01/10] staging: et131x: Converting et1310_mac.c function and local names from CamelCase Mark Einon
2011-07-10 15:35 ` [PATCH 02/10] staging: et131x: Converting et1310_phy.c " Mark Einon
2011-07-10 15:35 ` [PATCH 03/10] staging: et131x: Converting et1310_pm.c " Mark Einon
2011-07-10 15:35 ` Mark Einon [this message]
2011-07-10 15:35 ` [PATCH 05/10] staging: et131x: Converting et1310_rx.c " Mark Einon
2011-07-10 15:35 ` [PATCH 06/10] staging: et131x: Make static some local functions in et1310_rx.c Mark Einon
2011-07-10 15:35 ` [PATCH 07/10] staging: et131x: Converting et1310_rx.h variable names from CamelCase Mark Einon
2011-07-10 15:35 ` [PATCH 08/10] staging: et131x: add et1310_ prefix to et1310_mac.c functions Mark Einon
2011-07-10 15:35 ` [PATCH 09/10] staging: et131x: Converting et1310_tx.c function and local names from CamelCase Mark Einon
2011-07-10 15:35 ` [PATCH 10/10] staging: et131x: Converting et1310_adapter.h variable " Mark Einon
2011-08-23 18:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310312135-28407-5-git-send-email-mark.einon@gmail.com \
--to=mark.einon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox