Re: [PATCH] Remove incorrect usage of sysctl_vfs_cache_pressure

Dave Chinner
2011-07-11T02:01:00Z

On Mon, Jul 11, 2011 at 02:56:23AM +0530, raghu.prabhu13@gmail.com wrote:
> From: Raghavendra D Prabhu <rprabhu@wnohang.net>
>
> In shrinker functions, sysctl_vfs_cache_pressure variable is being used while
> trimming slab caches in general and not restricted to inode/dentry caches as
> documented for that sysctl.
>
> Raghavendra D Prabhu (1):
> mm/vmscan: Remove sysctl_vfs_cache_pressure from non-vfs shrinkers
>
> drivers/gpu/drm/i915/i915_gem.c | 2 +-

That's the only questionable use of it as it has nothing to do with
filesystems.

> fs/gfs2/glock.c | 2 +-
> fs/gfs2/quota.c | 2 +-
> fs/mbcache.c | 2 +-
> fs/nfs/dir.c | 2 +-
> fs/quota/dquot.c | 3 +--
> net/sunrpc/auth.c | 2 +-

All the others are filesystem₋specific caches and as such the use of
vfs_cache_pressure to adjust the balance of reclaim is valid usage.
Especially the VFS quota cache shrinkers. ;)

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com