From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] perf tools: Add missing 'node' alias to the hw_cache array
Date: Wed, 13 Jul 2011 23:06:08 +0200 [thread overview]
Message-ID: <1310591168.2586.39.camel@twins> (raw)
In-Reply-To: <20110713205818.GB7827@jolsa.brq.redhat.com>
On Wed, 2011-07-13 at 22:58 +0200, Jiri Olsa wrote:
> Adding "node" as a simple alias for NODE cache events.
>
> The addition of NODE cache events broke the parse_alias function,
> so any mismatched event caused the segfault, like:
>
> # ./perf stat -e krava ls
>
> The hw_cache/hw_cache_op/hw_cache_result arrays needs to follow
> PERF_COUNT_HW_CACHE_*MAX enums. Adding those MAXs to be size
> of those arrays, so possible ommision in future wil not lead to
> segfault.
>
> Adding read/write/prefetch as allowed operations for node cache
> event.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Thanks!
next prev parent reply other threads:[~2011-07-13 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1310483256-5772-1-git-send-email-jolsa@redhat.com>
[not found] ` <1310484647.14978.33.camel@twins>
[not found] ` <20110713204348.GA7827@jolsa.brq.redhat.com>
2011-07-13 20:58 ` [PATCHv2] perf tools: Add missing 'node' alias to the hw_cache array Jiri Olsa
2011-07-13 21:06 ` Peter Zijlstra [this message]
2011-07-21 10:09 ` [tip:perf/core] perf tools: Add missing 'node' alias to the hw_cache[] array tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310591168.2586.39.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox