From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Michael Neuling <mikey@neuling.org>,
Sonny Rao <sonnyrao@chromium.org>,
acme@redhat.com, anton@samba.org,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFCv3] perf: robustify proc and debugfs file recording
Date: Thu, 14 Jul 2011 14:55:30 +0200 [thread overview]
Message-ID: <1310648130.2586.251.camel@twins> (raw)
In-Reply-To: <1310647558.27864.19.camel@gandalf.stny.rr.com>
On Thu, 2011-07-14 at 08:45 -0400, Steven Rostedt wrote:
> ---
> tools/perf/util/trace-event-info.c | 120 ++++++++------------------------=
> -----
> 1 file changed, 29 insertions(+), 91 deletions(-)
>
> Index: linux-ozlabs/tools/perf/util/trace-event-info.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- linux-ozlabs.orig/tools/perf/util/trace-event-info.c 2011-07-13 20:42:2=
> 4.442945973 +1000
> +++ linux-ozlabs/tools/perf/util/trace-event-info.c 2011-07-14 10:14:19.072=
> 946058 +1000
> @@ -183,106 +183,59 @@
> return *ptr =3D=3D 0x01020304;
> }
> =20
> -static unsigned long long copy_file_fd(int fd)
> +/* unfortunately, you can not stat debugfs or proc files for size */
> +static void record_file(const char *file, size_t hdr_sz)
> {
> unsigned long long size =3D 0;
Yeah, its all the rage, we're supposed to write full RFC compliant email
parsers these days :(
/Content-Transfer-Encoding:.*quoted-printable.*/ {
decode = 1;
}
// {
tmp = $0
if (!decode) {
print tmp
next
}
if (concat) {
tmp = last tmp
concat = 0;
}
if (tmp ~ /=$/) {
concat = 1;
gsub("=$", "", tmp);
}
offset = 0;
while (match(tmp, /=[[:xdigit:]][[:xdigit:]]/, a)) {
if (a[0] < offset)
break;
hex = substr(a[0], 2)
char = sprintf("%c", strtonum("0x"hex))
gsub(a[0], char, tmp)
offset = a[0];
}
if (concat) {
last = tmp
next
}
print tmp
}
Should decode that crap I think..
next prev parent reply other threads:[~2011-07-14 12:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:15 [PATCH] [RFC] perf: robustify proc and debugfs file recording Sonny Rao
2011-07-12 21:19 ` Sonny Rao
2011-07-12 22:56 ` Steven Rostedt
2011-07-12 23:01 ` Sonny Rao
2011-07-12 23:29 ` Steven Rostedt
2011-07-13 10:39 ` Michael Neuling
2011-07-13 10:52 ` Michael Neuling
2011-07-13 17:45 ` Sonny Rao
2011-07-13 20:38 ` Steven Rostedt
2011-07-13 20:49 ` Sonny Rao
2011-07-13 20:58 ` Sonny Rao
2011-07-14 0:18 ` Michael Neuling
2011-07-14 0:40 ` [PATCH] [RFCv2] " Sonny Rao
2011-07-14 2:57 ` Steven Rostedt
2011-07-14 3:34 ` [PATCH] [RFCv3] " Michael Neuling
2011-07-14 12:45 ` Steven Rostedt
2011-07-14 12:55 ` Peter Zijlstra [this message]
2011-07-14 13:24 ` Steven Rostedt
2011-07-14 21:38 ` Michael Neuling
2011-07-14 21:54 ` Steven Rostedt
2011-07-14 22:03 ` Sonny Rao
2011-07-21 9:59 ` [tip:perf/core] perf: Robustify " tip-bot for Sonny Rao
2011-07-13 16:50 ` [RFC] perf: robustify " Riccardo Magliocchetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310648130.2586.251.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox