public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Ehrenberg <dehrenberg@google.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Sandeen <sandeen@redhat.com>
Cc: Dan Ehrenberg <dehrenberg@google.com>
Subject: [PATCH v2 2/2] ext4: Ignore a stripe width of 1
Date: Fri, 15 Jul 2011 14:41:55 -0700	[thread overview]
Message-ID: <1310766115-4164-2-git-send-email-dehrenberg@google.com> (raw)
In-Reply-To: <1310766115-4164-1-git-send-email-dehrenberg@google.com>

If the stripe width was set to 1, then this patch will ignore
that stripe width and ext4 will act as if the stripe width
were 0 with respect to optimizing allocations.

Signed-off-by: Dan Ehrenberg <dehrenberg@google.com>
---
 fs/ext4/super.c |   22 ++++++++++++++++------
 1 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9ea71aa..0a3745b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2383,17 +2383,27 @@ static unsigned long ext4_get_stripe_size(struct ext4_sb_info *sbi)
 	unsigned long stride = le16_to_cpu(sbi->s_es->s_raid_stride);
 	unsigned long stripe_width =
 			le32_to_cpu(sbi->s_es->s_raid_stripe_width);
+	int ret;
 
 	if (sbi->s_stripe && sbi->s_stripe <= sbi->s_blocks_per_group)
-		return sbi->s_stripe;
+		ret = sbi->s_stripe;
 
-	if (stripe_width <= sbi->s_blocks_per_group)
-		return stripe_width;
+	else if (stripe_width <= sbi->s_blocks_per_group)
+		ret = stripe_width;
 
-	if (stride <= sbi->s_blocks_per_group)
-		return stride;
+	else if (stride <= sbi->s_blocks_per_group)
+		ret = stride;
+	else
+		ret = 0;
 
-	return 0;
+	/*
+	 * If the stripe width is 1, this makes no sense and
+	 * we set it to 0 to turn off stripe handling code.
+	 */
+	if (ret <= 1)
+		ret = 0;
+
+	return ret;
 }
 
 /* sysfs supprt */
-- 
1.7.3.1


  reply	other threads:[~2011-07-15 21:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 21:41 [PATCH v2 1/2] ext4: Preallocation is a multiple of stripe size Dan Ehrenberg
2011-07-15 21:41 ` Dan Ehrenberg [this message]
2011-07-15 21:47   ` [PATCH v2 2/2] ext4: Ignore a stripe width of 1 Eric Sandeen
2011-07-18  1:21   ` Ted Ts'o
2011-07-18  1:13 ` [PATCH v2 1/2] ext4: Preallocation is a multiple of stripe size Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310766115-4164-2-git-send-email-dehrenberg@google.com \
    --to=dehrenberg@google.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox