From: Joe Perches <joe@perches.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
gregkh@suse.de, jim.cromie@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11 re-post] dynamic_debug: use a single printk() to emit msgs
Date: Fri, 15 Jul 2011 16:46:31 -0700 [thread overview]
Message-ID: <1310773591.10603.9.camel@Joe-Laptop> (raw)
In-Reply-To: <20110715195903.GA7470@redhat.com>
On Fri, 2011-07-15 at 15:59 -0400, Jason Baron wrote:
> here's Bart's suggestion as re-post. It looks much cleaner to
> me...
[]
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -422,52 +422,46 @@ static int ddebug_exec_query(char *query_string)
> return 0;
> }
>
> -static int dynamic_emit_prefix(const struct _ddebug *descriptor)
> +#define PREFIX_SIZE 64
> +#define LEFT(wrote) ((PREFIX_SIZE - wrote) > 0) ? (PREFIX_SIZE - wrote) : 0
> +
> +static char *dynamic_emit_prefix(const struct _ddebug *desc, char *buf)
> {
> - char tid[sizeof(int) + sizeof(int)/2 + 4];
> - char lineno[sizeof(int) + sizeof(int)/2];
> + int pos = 0;
>
> - if (descriptor->flags & _DPRINTK_FLAGS_INCL_TID) {
> + pos += snprintf(buf + pos, LEFT(pos), "%s", KERN_DEBUG);
> + if (desc->flags & _DPRINTK_FLAGS_INCL_TID) {
> if (in_interrupt())
> - snprintf(tid, sizeof(tid), "%s", "<intr> ");
> + pos += snprintf(buf + pos, LEFT(pos), "%s ",
> + "<intr>");
scnprintf works without using LEFT.
snprintf does as well.
http://lkml.org/lkml/2010/7/23/375
next prev parent reply other threads:[~2011-07-15 23:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 16:09 [PATCH 00/11] various fixes v2 Jason Baron
2011-07-14 16:09 ` [PATCH 01/11] dynamic_debug: Add __dynamic_dev_dbg Jason Baron
2011-07-14 16:09 ` [PATCH 02/11] dynamic_debug: Consolidate prefix output to single routine Jason Baron
2011-07-14 16:09 ` [PATCH 03/11] dynamic_debug: Remove uses of KERN_CONT in dynamic_emit_prefix Jason Baron
2011-07-15 10:04 ` Bart Van Assche
2011-07-15 15:07 ` Jason Baron
2011-07-15 15:54 ` Joe Perches
2011-07-14 16:09 ` [PATCH 04/11] dynamic_debug: Convert printks to pr_<level> Jason Baron
2011-07-14 16:09 ` [PATCH 05/11] dynamic_debug: remove unused control variables Jason Baron
2011-07-14 16:09 ` [PATCH 06/11] dynamic_debug: add Jason Baron as maintainer Jason Baron
2011-07-14 16:09 ` [PATCH 07/11] dynamic_debug: make netdev_dbg() call __netdev_printk() Jason Baron
2011-07-14 16:09 ` [PATCH 08/11] dynamic_debug: make netif_dbg() " Jason Baron
2011-07-14 16:09 ` [PATCH 09/11] dynamic_debug: consolidate repetitive struct _ddebug descriptor definitions Jason Baron
2011-07-14 16:09 ` [PATCH 10/11] dynamic_debug: remove num_enabled accounting Jason Baron
2011-07-14 16:09 ` [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs Jason Baron
2011-07-15 6:41 ` Joe Perches
2011-07-15 10:05 ` Bart Van Assche
2011-07-15 15:48 ` Joe Perches
2011-07-15 15:57 ` Bart Van Assche
2011-07-15 16:04 ` Jason Baron
2011-07-15 16:10 ` Joe Perches
2011-07-15 16:10 ` Bart Van Assche
2011-07-15 16:16 ` Joe Perches
2011-07-15 19:59 ` [PATCH 11/11 re-post] " Jason Baron
2011-07-15 23:46 ` Joe Perches [this message]
2011-07-18 14:30 ` Jason Baron
2011-07-18 14:50 ` Joe Perches
2011-07-15 16:08 ` [PATCH 11/11] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310773591.10603.9.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bvanassche@acm.org \
--cc=gregkh@suse.de \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox