[PATCH v2 2/5] cpu: CPU notifier error injection

Akinobu Mita
2011-07-18T01:15:42Z

This provides the ability to inject artifical errors to CPU notifier
chain callbacks. It is controlled through debugfs interface under
/sys/kernel/debug/cpu-notifier-error-inject/

Each of the files in the directory represents an event which can be
failed and contains the error code. If the notifier call chain should
be failed with some events notified, write the error code to the files.

Example1: inject CPU offline error (-1 == -EPERM)

# echo -1 > /sys/kernel/debug/cpu-notifier-error-inject/CPU_UP_PREPARE
# echo 0 > /sys/devices/system/cpu/cpu1/online
bash: echo: write error: Operation not permitted

Example2: inject CPU online error (-2 == -ENOENT)

# echo -2 > /sys/kernel/debug/cpu-notifier-error-inject/CPU_DOWN_PREPARE
# echo 1 > /sys/devices/system/cpu/cpu1/online
bash: echo: write error: No such file or directory

This also schedules cpu-notifier-error-inject.ko module for removal in
favor of more generic interface.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
* v2
- improve Kconfig help text

Documentation/feature-removal-schedule.txt | 8 +++++++
kernel/cpu.c | 31 ++++++++++++++++++++++++++++
lib/Kconfig.debug | 20 ++++++++++++++++++
3 files changed, 59 insertions(+), 0 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 72e2384..cf0b4b7 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -583,3 +583,11 @@ Why: Superseded by the UVCIOC_CTRL_QUERY ioctl.
Who: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

----------------------------
+
+What: Support for CPU_NOTIFIER_ERROR_INJECT (cpu-notifier-error-inject.ko)
+When: 3.3
+Why: Replaced with more generic debugfs interface in
+ /sys/kernel/debug/cpu-notifier-error-inject/
+Who: Akinobu Mita <akinobu.mita@gmail.com>
+
+----------------------------
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 12b7458..c326f4d 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -170,6 +170,37 @@ void __ref unregister_cpu_notifier(struct notifier_block *nb)
}
EXPORT_SYMBOL(unregister_cpu_notifier);

+#ifdef CONFIG_CPU_NOTIFIER_ERROR_INJECTION
+
+static struct err_inject_notifier_block err_inject_cpu_notifier = {
+ .actions = {
+ { ERR_INJECT_NOTIFIER_ACTION(CPU_UP_PREPARE) },
+ { ERR_INJECT_NOTIFIER_ACTION(CPU_UP_PREPARE_FROZEN) },
+ { ERR_INJECT_NOTIFIER_ACTION(CPU_DOWN_PREPARE) },
+ { ERR_INJECT_NOTIFIER_ACTION(CPU_DOWN_PREPARE_FROZEN) },
+ {}
+ }
+};
+
+static int __init err_inject_cpu_notifier_init(void)
+{
+ int err;
+
+ err = err_inject_notifier_block_init(&err_inject_cpu_notifier,
+ "cpu-notifier-error-inject", -1);
+ if (err)
+ return err;
+
+ err = register_hotcpu_notifier(&err_inject_cpu_notifier.nb);
+ if (err)
+ err_inject_notifier_block_cleanup(&err_inject_cpu_notifier);
+
+ return err;
+}
+late_initcall(err_inject_cpu_notifier_init);
+
+#endif /* CONFIG_CPU_NOTIFIER_ERROR_INJECTION */
+
static inline void check_for_tasks(int cpu)
{
struct task_struct *p;
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8c6ce7e..d1bbedd 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1029,6 +1029,26 @@ config NOTIFIER_ERROR_INJECTION

Say N if unsure.

+config CPU_NOTIFIER_ERROR_INJECTION
+ bool "CPU notifier error injection"
+ depends on HOTPLUG_CPU && NOTIFIER_ERROR_INJECTION
+ help
+ This option provides the ability to inject artifical errors to
+ CPU notifier chain callbacks. It is controlled through debugfs
+ interface under /sys/kernel/debug/cpu-notifier-error-inject/
+
+ Each of the files in the directory represents an event which can be
+ failed and contains the error code. If the notifier call chain
+ should be failed with some events notified, write the error code to
+ the files.
+
+ Example: Inject CPU offline error (-1 == -EPERM)
+
+ # cd /sys/kernel/debug/cpu-notifier-error-inject
+ # echo -1 > CPU_UP_PREPARE
+ # echo 0 > /sys/devices/system/cpu/cpu1/online
+ bash: echo: write error: Operation not permitted
+
config CPU_NOTIFIER_ERROR_INJECT
tristate "CPU notifier error injection module"
depends on HOTPLUG_CPU && DEBUG_KERNEL
--
1.7.4.4