From: Joe Perches <joe@perches.com>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH 1/2] serial:blackfin: Correct coding style in bfin serial driver.
Date: Tue, 19 Jul 2011 08:28:35 -0700 [thread overview]
Message-ID: <1311089315.2286.157.camel@Joe-Laptop> (raw)
In-Reply-To: <1311070165-29402-1-git-send-email-sonic.adi@gmail.com>
On Tue, 2011-07-19 at 18:09 +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
[]
> @@ -1091,10 +1090,18 @@ bfin_serial_console_get_options(struct bfin_serial_port *uart, int *baud,
> *parity = 'o';
> }
> switch (lcr & 0x03) {
> - case 0: *bits = 5; break;
> - case 1: *bits = 6; break;
> - case 2: *bits = 7; break;
> - case 3: *bits = 8; break;
> + case 0:
> + *bits = 5;
> + break;
> + case 1:
> + *bits = 6;
> + break;
> + case 2:
> + *bits = 7;
> + break;
> + case 3:
> + *bits = 8;
> + break;
> }
Maybe just:
*bits = 5 + (lcr & 3);
next prev parent reply other threads:[~2011-07-19 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 10:09 [PATCH 1/2] serial:blackfin: Correct coding style in bfin serial driver Sonic Zhang
2011-07-19 10:09 ` [PATCH 2/2] serial:blackfin: rename Blackfin serial driver to bfin_uart.c Sonic Zhang
2011-07-19 16:05 ` Alan Cox
2011-07-19 15:28 ` Joe Perches [this message]
2011-07-20 2:44 ` [PATCH 1/2] serial:blackfin: Correct coding style in bfin serial driver Zhang, Sonic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311089315.2286.157.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox