From: Chris Mason <chris.mason@oracle.com>
To: paulmck <paulmck@linux.vnet.ibm.com>
Cc: "Jan H. Schönherr" <schnhrr@cs.tu-berlin.de>,
"Dipankar Sarma" <dipankar@in.ibm.com>,
"Corey Minyard" <minyard@acm.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: Fix wrong check in list_splice_init_rcu()
Date: Tue, 19 Jul 2011 17:00:11 -0400 [thread overview]
Message-ID: <1311109131-sup-1906@shiny> (raw)
In-Reply-To: <20110719202752.GO2357@linux.vnet.ibm.com>
Excerpts from Paul E. McKenney's message of 2011-07-19 16:27:52 -0400:
> On Tue, Jul 19, 2011 at 09:10:26PM +0200, Jan H. Schönherr wrote:
> > Hi.
> >
> > If I don't miss something obvious, the following patch would
> > be a good idea.
> >
> > There are currently two users of list_splice_init_rcu(): IPMI and btrfs.
> > For these, list_splice_init_rcu() is currently a NOP.
> >
> > If I interpret the code correctly, this fixes a memory leak for
> > IPMI and something probably worse for btrfs.
> >
> > The call from within btrfs was introduced only after v2.6.39 with commit
> > 1f78160 ("Btrfs: using rcu lock in the reader side of devices list") by
> > converting a list_splice_init() call.
> >
> > Therefore, this patch might be a candidate for v3.0.
>
> Excellent catch! This one has been around for some time, so my guess
> is that it goes into v3.1. Either way, I have queued it, thank you!
A good catch and thanks for the cc. The btrfs code in question here has
some other problems, and it's fine if this patch doesn't make 3.0.
-chris
prev parent reply other threads:[~2011-07-19 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:10 [PATCH] rcu: Fix wrong check in list_splice_init_rcu() Jan H. Schönherr
2011-07-19 20:27 ` Paul E. McKenney
2011-07-19 21:00 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311109131-sup-1906@shiny \
--to=chris.mason@oracle.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=schnhrr@cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox