From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6655: simplify MAC printing by using %pMF
Date: Thu, 21 Jul 2011 07:24:16 -0700 [thread overview]
Message-ID: <1311258256.1663.35.camel@Joe-Laptop> (raw)
In-Reply-To: <c8400fbc4ad3a91885fcda0e080be0ae80fcf077.1311252059.git.andriy.shevchenko@linux.intel.com>
On Thu, 2011-07-21 at 15:42 +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> drivers/staging/vt6655/device_main.c | 10 +-----
> drivers/staging/vt6655/dpc.c | 30 ++++----------------
> drivers/staging/vt6655/wmgr.c | 49 +++++++---------------------------
[ patches like ]
> + DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Probe request rx:MAC addr:%pMF\n",
> + sFrame.pHdr->sA3.abyAddr2);
Please use %pM here and in [2/2] as well.
%pMF should be used only for FDDI.
It looks as if this was someones idea to separate
the OUI out of the mac address.
next prev parent reply other threads:[~2011-07-21 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 12:42 [PATCH 1/2] staging: vt6655: simplify MAC printing by using %pMF Andy Shevchenko
2011-07-21 12:42 ` [PATCH 2/2] staging: vt6656: use %pMF for printing MACs Andy Shevchenko
2011-07-21 14:24 ` Joe Perches [this message]
2011-07-26 7:35 ` [PATCHv2 1/2] staging: vt6655: simplify MAC printing by using %pM Andy Shevchenko
2011-07-26 7:35 ` [PATCHv2 2/2] staging: vt6656: use %pM for printing MACs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311258256.1663.35.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox