From: Liam Girdwood <lrg@kernel.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org, Graeme Gregory <gg@slimlogic.co.uk>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v2] regulator: tps65910: Add missing breaks in switch/case
Date: Fri, 22 Jul 2011 11:47:38 +0100 [thread overview]
Message-ID: <1311331658.3312.11.camel@odin> (raw)
In-Reply-To: <20110710110943.GA24191@opensource.wolfsonmicro.com>
On Sun, 2011-07-10 at 20:09 +0900, Mark Brown wrote:
> On Sun, Jul 10, 2011 at 06:41:22PM +0800, Axel Lin wrote:
> > Also add a default case in tps65910_list_voltage_dcdc to silence
> > 'volt' may be used uninitialized in this function warning.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> though for the default case I'd suggest also adding a BUG() as if that
> happens either the driver is confused or the core is making up
> regulators for us.
> --
Applied.
Thanks
Liam
prev parent reply other threads:[~2011-07-22 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 10:41 [PATCH v2] regulator: tps65910: Add missing breaks in switch/case Axel Lin
2011-07-10 11:09 ` Mark Brown
2011-07-22 10:47 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311331658.3312.11.camel@odin \
--to=lrg@kernel.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox