Re: [patch 01/18] sched: (fixlet) dont update shares twice on on_rq parent

Kamalesh Babulal
2011-07-22T11:06:47Z

* Paul Turner <pjt@google.com> [2011-07-21 09:43:26]:

> In dequeue_task_fair() we bail on dequeue when we encounter a parenting entity
> with additional weight. However, we perform a double shares update on this
> entity as we continue the shares update traversal from this point, despite
> dequeue_entity() having already updated its queuing cfs_rq.
> Avoid this by starting from the parent when we resume.
>
> Signed-off-by: Paul Turner <pjt@google.com>
> ---
> kernel/sched_fair.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: tip/kernel/sched_fair.c
> ===================================================================
> --- tip.orig/kernel/sched_fair.c
> +++ tip/kernel/sched_fair.c
> @@ -1370,6 +1370,9 @@ static void dequeue_task_fair(struct rq
> */
> if (task_sleep && parent_entity(se))
> set_next_buddy(parent_entity(se));
> +
> + /* avoid re-evaluating load for this entity */
> + se = parent_entity(se);
> break;
> }
> flags |= DEQUEUE_SLEEP;
>
this patch has been merged into tip

commit 9598c82dcacadc3b9daa8170613fd054c6124d30
Author: Paul Turner <pjt@google.com>
Date: Wed Jul 6 22:30:37 2011 -0700

sched: Don't update shares twice on on_rq parent