From: Steven Rostedt <srostedt@redhat.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/4] kbuild: export MAKECMDGOALS
Date: Mon, 25 Jul 2011 09:14:00 -0400 [thread overview]
Message-ID: <1311599640.3064.0.camel@fedora> (raw)
In-Reply-To: <4E258FAE.6040807@suse.cz>
On Tue, 2011-07-19 at 16:07 +0200, Michal Marek wrote:
> On 18.7.2011 21:05, Arnaud Lacombe wrote:
> > Hi,
> >
> > On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe<lacombar@gmail.com> wrote:
> >> Cc: Steven Rostedt<srostedt@redhat.com>
> >> ---
> >> Makefile | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index afb8e0d..ea517fd 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -22,6 +22,9 @@ LC_COLLATE=C
> >> LC_NUMERIC=C
> >> export LC_COLLATE LC_NUMERIC
> >>
> >> +# Export make goals
> >> +export MAKECMDGOALS
> >> +
> >> # We are using a recursive build, so we need to do a little thinking
> >> # to get the ordering right.
> >> #
> > Michal, before I send a new version of this serie, can you tell me
> > your point of view on the export of MAKECMDGOALS (or
> > KBUILD_MAKECMDGOALS) and Kconfig to the environment ?
>
> A cleaner interface would IMO be to check the target in the makefile and
> pass a commandline option to streamline_config.pl, so that it's easier
> to run it manually.
I agree with this. As I've been told by many people that they prefer to
run streamline_config.pl directly.
-- Steve
next prev parent reply other threads:[~2011-07-25 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 23:31 [RFC 0/4] streamline_config clean-ups Arnaud Lacombe
2011-07-01 23:31 ` [RFC 1/4] kbuild: export MAKECMDGOALS Arnaud Lacombe
2011-07-18 19:05 ` Arnaud Lacombe
2011-07-19 14:07 ` Michal Marek
2011-07-19 16:28 ` Arnaud Lacombe
2011-07-25 13:14 ` Steven Rostedt [this message]
2011-07-01 23:31 ` [RFC 2/4] kconfig/streamline_config.pl: directly access LSMOD Arnaud Lacombe
2011-07-01 23:31 ` [RFC 3/4] kconfig/streamline_config.pl: merge local{mod,yes}config Arnaud Lacombe
2011-07-01 23:31 ` [RFC 4/4] kconfig/streamline_config.pl: move config generation to script Arnaud Lacombe
2011-07-08 21:47 ` [RFC 0/4] streamline_config clean-ups Arnaud Lacombe
2011-07-09 0:19 ` Steven Rostedt
2011-07-14 0:54 ` Steven Rostedt
2011-07-14 2:41 ` Arnaud Lacombe
2011-07-14 13:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311599640.3064.0.camel@fedora \
--to=srostedt@redhat.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox