From: Joe Perches <joe@perches.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c
Date: Mon, 25 Jul 2011 22:27:14 -0700 [thread overview]
Message-ID: <1311658034.26957.3.camel@Joe-Laptop> (raw)
In-Reply-To: <1311658020-16057-1-git-send-email-ravishankarkm32@gmail.com>
On Tue, 2011-07-26 at 10:57 +0530, Ravishankar wrote:
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
[]
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
[]
> - printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> + pr_info("c6xdigio_pwmo_insn_read %x\n", insn->n);
It would be good if you would convert embedded function names
to "%s", __func__. Maybe convert the bare printks to appropriate
levels as well. Perhaps:
pr_debug("%s: %x\n", __func__, insn->n);
next prev parent reply other threads:[~2011-07-26 5:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi: fix printk issue in c6xdigio.c>
2011-07-26 5:27 ` [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c Ravishankar
2011-07-26 5:27 ` Joe Perches [this message]
2011-07-26 6:45 ` [PATCH 1/1 v2] " Ravishankar
2011-07-26 6:41 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311658034.26957.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox