From: Ravishankar <ravishankarkm32@gmail.com>
To: gregkh@suse.de, wfp5p@virginia.edu
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>,
Ravishankar <ravishankarkm32@gmail.com>
Subject: [PATCH] Staging: comedi: fix printk issue in adv_pci_dio.c
Date: Wed, 27 Jul 2011 12:01:24 +0530 [thread overview]
Message-ID: <1311748284-19756-1-git-send-email-ravishankarkm32@gmail.com> (raw)
In-Reply-To: <[PATCH]Staging: Comedi: fix printk issue in adv_pci_dio.c>
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the adv_pci_dio.c file that fixes up a printk warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c b/drivers/staging/comedi/drivers/adv_pci_dio.c
index d23799b..1d2261f 100644
--- a/drivers/staging/comedi/drivers/adv_pci_dio.c
+++ b/drivers/staging/comedi/drivers/adv_pci_dio.c
@@ -1106,11 +1106,11 @@ static int pci_dio_attach(struct comedi_device *dev,
unsigned long iobase;
struct pci_dev *pcidev = NULL;
- printk("comedi%d: adv_pci_dio: ", dev->minor);
+ printk(KERN_INFO "comedi%d: adv_pci_dio: ", dev->minor);
ret = alloc_private(dev, sizeof(struct pci_dio_private));
if (ret < 0) {
- printk(", Error: Cann't allocate private memory!\n");
+ printk(KERN_CONT ", Error: Cann't allocate private memory!\n");
return -ENOMEM;
}
@@ -1140,19 +1140,19 @@ static int pci_dio_attach(struct comedi_device *dev,
}
if (!dev->board_ptr) {
- printk(", Error: Requested type of the card was not found!\n");
+ printk(KERN_ERR ", Error: Requested type of the card was not found!\n");
return -EIO;
}
if (comedi_pci_enable(pcidev, driver_pci_dio.driver_name)) {
printk
- (", Error: Can't enable PCI device and request regions!\n");
+ (KERN_ERR ", Error: Can't enable PCI device and request "
+ "regions!\n");
return -EIO;
}
iobase = pci_resource_start(pcidev, this_board->main_pci_region);
- printk(", b:s:f=%d:%d:%d, io=0x%4lx",
- pcidev->bus->number, PCI_SLOT(pcidev->devfn),
- PCI_FUNC(pcidev->devfn), iobase);
+ printk(KERN_INFO ", b:s:f=%d:%d:%d, io=0x%4lx",
+ pcidev->bus->number, PCI_SLOT(pcidev->devfn),
+ PCI_FUNC(pcidev->devfn), iobase);
dev->iobase = iobase;
dev->board_name = this_board->name;
@@ -1178,11 +1178,11 @@ static int pci_dio_attach(struct comedi_device *dev,
ret = alloc_subdevices(dev, n_subdevices);
if (ret < 0) {
- printk(", Error: Cann't allocate subdevice memory!\n");
+ printk(KERN_CONT ", Error: Cann't allocate subdevice memory!\n");
return ret;
}
- printk(".\n");
+ printk(KERN_CONT ".\n");
subdev = 0;
--
1.6.5.2
next parent reply other threads:[~2011-07-27 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: Comedi: fix printk issue in adv_pci_dio.c>
2011-07-27 6:31 ` Ravishankar [this message]
2011-07-27 6:38 ` [PATCH] Staging: comedi: fix printk issue in adv_pci_dio.c Joe Perches
2011-07-27 11:40 ` [PATCH v2] " Ravishankar
2011-07-27 12:35 ` Jesper Juhl
[not found] ` <CAEP+3ODJLKhP5Vh1gYyiWqoNaUTt75O5ZBdCfurwjGe5K02eFA@mail.gmail.com>
2011-07-28 5:45 ` ravi shankar
2011-07-28 19:32 ` Jesper Juhl
2011-07-29 11:06 ` Ravishankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311748284-19756-1-git-send-email-ravishankarkm32@gmail.com \
--to=ravishankarkm32@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox