From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Michael Rubin <mrubin@google.com>,
David Sharp <dhsharp@google.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs
Date: Thu, 28 Jul 2011 16:10:04 +0200 [thread overview]
Message-ID: <1311862204.2617.179.camel@laptop> (raw)
In-Reply-To: <20110728123131.GA11820@somewhere.redhat.com>
On Thu, 2011-07-28 at 14:31 +0200, Frederic Weisbecker wrote:
>
> Because that requires to put the tracepoints in every interrupt sources
> for every archs instead of putting one in the generic space.
To sum up from IRC, yes that's exactly what you need to do, because this
patch set assumes two things:
1) that there is a 1:1 mapping between interrupt sources and generic
handlers, and
2) that there is a neglectable amount of arch specific code for each
generic handler.
Both are false in generic. Therefore there is no option but to
instrument each and every arch specific interrupt handler.
Also, please use a single tracepoint for all that instead of this horrid
forest of random crap. Use something like arch_interrupt_enter(line_nr),
arch_interrupt_exit(line_nr).
next prev parent reply other threads:[~2011-07-28 14:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 21:38 [PATCH 0/6] Add tracepoints to trace all system IRQs Vaibhav Nagarnaik
2011-07-14 21:38 ` [PATCH 1/6] trace,x86: Add tracepoint to x86 timer interrupt handler Vaibhav Nagarnaik
2011-07-14 21:38 ` [PATCH 2/6] trace: Add tracepoints to timer interrupt handlers Vaibhav Nagarnaik
2011-07-14 21:38 ` [PATCH 3/6] trace: Add tracepoints to IRQ work run handler Vaibhav Nagarnaik
2011-07-14 22:09 ` Frederic Weisbecker
2011-07-14 23:01 ` Vaibhav Nagarnaik
2011-07-14 21:38 ` [PATCH 4/6] trace: Add tracepoints to reschedule interrupt handler Vaibhav Nagarnaik
2011-07-14 22:02 ` Frederic Weisbecker
2011-07-15 8:48 ` Peter Zijlstra
2011-07-15 17:50 ` David Sharp
2011-07-21 12:31 ` Peter Zijlstra
2011-07-21 18:04 ` Vaibhav Nagarnaik
2011-07-14 21:38 ` [PATCH 5/6] trace: Add tracepoints to call function interrupt handlers Vaibhav Nagarnaik
2011-07-14 22:05 ` Frederic Weisbecker
2011-07-14 23:02 ` Vaibhav Nagarnaik
2011-07-14 23:05 ` Frederic Weisbecker
2011-07-14 21:38 ` [PATCH 6/6] trace,x86: Add platform_irq_vector_{entry|exit} trace events Vaibhav Nagarnaik
2011-07-27 18:57 ` [PATCH v2 0/6] Add tracepoints to trace all system IRQs Vaibhav Nagarnaik
2011-07-28 12:12 ` Peter Zijlstra
2011-07-28 12:31 ` Frederic Weisbecker
2011-07-28 12:53 ` Peter Zijlstra
2011-07-28 13:09 ` Frederic Weisbecker
2011-07-28 13:28 ` Peter Zijlstra
2011-07-28 14:10 ` Peter Zijlstra [this message]
2011-07-28 14:08 ` Frederic Weisbecker
2011-07-28 17:39 ` Vaibhav Nagarnaik
2011-07-27 18:57 ` [PATCH v2 1/6] trace,x86: Add tracepoint to x86 timer interrupt handler Vaibhav Nagarnaik
2011-07-27 18:57 ` [PATCH v2 2/6] trace: Add tracepoints to timer interrupt handlers Vaibhav Nagarnaik
2011-07-27 18:57 ` [PATCH v2 3/6] trace: Add tracepoints to IRQ work run handler Vaibhav Nagarnaik
2011-07-28 12:12 ` Peter Zijlstra
2011-07-28 13:29 ` Frederic Weisbecker
2011-07-28 13:49 ` Peter Zijlstra
2011-07-28 14:04 ` Frederic Weisbecker
2011-07-27 18:57 ` [PATCH v2 4/6] trace: Add tracepoints to reschedule interrupt handler Vaibhav Nagarnaik
2011-07-28 12:12 ` Peter Zijlstra
2011-07-27 18:57 ` [PATCH v2 5/6] trace: Add tracepoints to call function interrupt handlers Vaibhav Nagarnaik
2011-07-28 12:17 ` Peter Zijlstra
2011-07-27 18:57 ` [PATCH v2 6/6] trace,x86: Add platform_irq_vector_{entry|exit} trace events Vaibhav Nagarnaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311862204.2617.179.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mrubin@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vnagarnaik@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox