Re: [PATCH] blktrace: add FLUSH/FUA support

Namhyung Kim
2011-06-08T03:11:27Z

2011-06-07 (화), 19:20 -0400, Steven Rostedt:
> On Wed, 2011-06-01 at 17:38 +0900, Namhyung Kim wrote:
> > diff --git a/include/trace/events/block.h b/include/trace/events/block.h
> > index bf366547da25..f21fea24216d 100644
> > --- a/include/trace/events/block.h
> > +++ b/include/trace/events/block.h
> > @@ -19,7 +19,7 @@ DECLARE_EVENT_CLASS(block_rq_with_error,
> > __field( sector_t, sector )
> > __field( unsigned int, nr_sector )
> > __field( int, errors )
> > - __array( char, rwbs, 6 )
> > + __array( char, rwbs, 8 )
> > __dynamic_array( char, cmd, blk_cmd_buf_len(rq) )
> > ),
> >
> > @@ -104,7 +104,7 @@ DECLARE_EVENT_CLASS(block_rq,
> > __field( sector_t, sector )
> > __field( unsigned int, nr_sector )
> > __field( unsigned int, bytes )
> > - __array( char, rwbs, 6 )
> > + __array( char, rwbs, 8 )
> > __array( char, comm, TASK_COMM_LEN )
> > __dynamic_array( char, cmd, blk_cmd_buf_len(rq) )
> > ),
> > @@ -183,7 +183,7 @@ TRACE_EVENT(block_bio_bounce,
> > __field( dev_t, dev )
> > __field( sector_t, sector )
> > __field( unsigned int, nr_sector )
> > - __array( char, rwbs, 6 )
> > + __array( char, rwbs, 8 )
> > __array( char, comm, TASK_COMM_LEN )
> > ),
> >
>
>
> Wouldn't it be better to replace all these "6" and "8"'s with a macro?
> Then it would be a heck of a lot easier to change in the future.
>
> -- Steve
>
>

Will fix in the next version, Thanks.

--
Regards,
Namhyung Kim