From: "Alex,Shi" <alex.shi@intel.com>
To: Mel Gorman <mgorman@suse.de>
Cc: "minchan.kim@gmail.com" <minchan.kim@gmail.com>,
"stable@kernel.org" <stable@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andrea@cpushare.com" <andrea@cpushare.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [PATCH] kswapd: assign new_order and new_classzone_idx after wakeup in sleeping
Date: Fri, 29 Jul 2011 08:10:38 +0800 [thread overview]
Message-ID: <1311898238.27358.2416.camel@debian> (raw)
In-Reply-To: <20110728111203.GM3010@suse.de>
> Post to linux-mm, cc me.
>
> > > Acked-by: Mel Gorman <mgorman@suse.de>
> > >
> > > It won't be merged to -stable until it goes to mainline though so
> > > minimally you need to post this to linux-mm.
> > >
> > > For -stable, you should explain why it is a candidate. I didn't push
> > > the patch at the time because user problems were already resolved
> > > and I wanted the merged for 3.0 before revisiting it. What problem
> > > did you observe without this patch? With the lack of reference to
> > > the other thread or the previous patch, I'm assuming you found and
> > > solved the problem independently and I'd like to add a test case.
> >
> > Actually, our LKP testing didn't find this problem on this point. Even
> > with the patch, performance has no change on our machines. I just find
> > this by my eyes.
> >
>
> Dang. I figured all right that it was unlikely the patch would
> actually fix any problem but it looks correct and shouldnt' cause a
> regression. You should resend the patch to Andrew cc'ing the people
> in the old thread and linux-mm and ask Padraig Brady to test the
> patch to confirm his problem does not reappear. When it gets into
> mainline, try for -stable but I think there is very little motivation
> for merging it there.
Thanks a lot for the suggestions. I will do them.
next prev parent reply other threads:[~2011-07-29 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 8:11 [PATCH] kswapd: assign new_order and new_classzone_idx after wakeup in sleeping Alex Shi
2011-07-28 10:19 ` Mel Gorman
2011-07-28 10:47 ` Alex,Shi
2011-07-28 11:12 ` Mel Gorman
2011-07-29 0:10 ` Alex,Shi [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-29 1:34 Alex Shi
2011-07-29 8:57 ` Minchan Kim
2011-07-29 15:33 ` Shi, Alex
2011-07-29 1:45 Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311898238.27358.2416.camel@debian \
--to=alex.shi@intel.com \
--cc=andrea@cpushare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=shaohua.li@intel.com \
--cc=stable@kernel.org \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox