From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/locking] lockdep: Fix lockdep_no_validate against IRQ states
Date: Fri, 29 Jul 2011 07:54:16 +0200 [thread overview]
Message-ID: <1311918856.5890.212.camel@twins> (raw)
In-Reply-To: <4E322B19.3020604@cn.fujitsu.com>
On Fri, 2011-07-29 at 11:38 +0800, Li Zefan wrote:
> > + if (hlock_class(hlock)->key ==
> &__lockdep_no_validate__)
> > + continue;
> > +
>
> The 2 pointers are not the same type.
>
> kernel/lockdep.c: In function 'mark_held_locks':
> kernel/lockdep.c:2471:31: warning: comparison of distinct pointer
> types lacks a cast
Yeah, I know, I've even got a fix queued up.. Thanks though.
prev parent reply other threads:[~2011-07-29 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 19:32 [tip:core/locking] lockdep: Fix lockdep_no_validate against IRQ states tip-bot for Peter Zijlstra
2011-07-29 3:38 ` Li Zefan
2011-07-29 5:54 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311918856.5890.212.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox