[PATCH] power_supply: max8998_charger: allow full timeout not set, leave it unchanged

[PATCH] power_supply: max8998_charger: allow full timeout not set, leave it unchanged

[Axel Lin]

Add a missing break for case 0 of pdata->timeout, otherwise it will fall
through to the default case and return error.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/power/max8998_charger.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/power/max8998_charger.c b/drivers/power/max8998_charger.c
index 4ddacb4..f793711 100644
--- a/drivers/power/max8998_charger.c
+++ b/drivers/power/max8998_charger.c
@@ -152,6 +152,7 @@ static __devinit int max8998_battery_probe(struct platform_device *pdev)
 	case 0:
 		dev_dbg(max8998->dev,
 			"Full Timeout not set: leave it unchanged.\n");
+		break;
 	default:
 		dev_err(max8998->dev, "Invalid Full Timeout value\n");
 		ret = -EINVAL;
-- 
1.7.4.1

Re: [PATCH] power_supply: max8998_charger: allow full timeout not set, leave it unchanged

[함명주]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 742 bytes --]

Sender : Axel Lin<axel.lin@gmail.com>
Date : 2011-08-01 08:41 (GMT+09:00)
> Add a missing break for case 0 of pdata->timeout, otherwise it will fall
> through to the default case and return error.
>
> Signed-off-by: Axel Lin 
> ---
> drivers/power/max8998_charger.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Thank you for pointing that out.

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>


 MyungJoo Ham (ÇÔ¸íÁÖ)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] power_supply: max8998_charger: allow full timeout not set, leave it unchanged

[Anton Vorontsov]

On Mon, Aug 01, 2011 at 02:16:19AM +0000, 함명주 wrote:
> Sender : Axel Lin<axel.lin@gmail.com>
> Date : 2011-08-01 08:41 (GMT+09:00)
> > Add a missing break for case 0 of pdata->timeout, otherwise it will fall
> > through to the default case and return error.
> >
> > Signed-off-by: Axel Lin 
> > ---
> > drivers/power/max8998_charger.c |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Thank you for pointing that out.
> 
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Applied, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com