From: Joe Perches <joe@perches.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH] Staging: comedi: fix printk issue in pcl818.c
Date: Tue, 02 Aug 2011 23:10:53 -0700 [thread overview]
Message-ID: <1312351854.26546.9.camel@Joe-Laptop> (raw)
In-Reply-To: <1312349090-31007-1-git-send-email-ravishankarkm32@gmail.com>
On Wed, 2011-08-03 at 10:54 +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool
This patch does a lot more than fix a printk warning.
Please make your patch descriptions match your patch.
> drivers/staging/comedi/drivers/pcl818.c | 118 +++++++++++++++----------------
> @@ -1461,7 +1452,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> struct comedi_cmd *cmd = &s->async->cmd;
> int retval;
>
> - printk("pcl818_ai_cmd()\n");
> + dev_dbg(dev->hw_dev "pcl818_ai_cmd()\n");
Compile your patches _before_ sending them.
prev parent reply other threads:[~2011-08-03 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: Comedi: fix printk issues in pcl818.c>
2011-08-03 5:24 ` [PATCH] Staging: comedi: fix printk issue in pcl818.c Ravishankar
2011-08-03 6:10 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312351854.26546.9.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox