Re: [tip:perf/urgent] perf sched: Fix list of events, dropping unsupported ':r' modifier

Arnaldo Carvalho de Melo
2011-08-03T17:06:50Z

Em Wed, Aug 03, 2011 at 02:18:51PM +0200, Peter Zijlstra escreveu:
> On Wed, 2011-08-03 at 14:11 +0200, Frederic Weisbecker wrote:
> > Look at tools/perf/util/parse-events.c:parse_single_tracepoint_event()
>
> fscking tinkerers.. that's horrid... strncmp("record") seriously wtf
> were you smoking, Acme why did you ever merge crap like that?

I haven't :-)

> Also, acme that can break stuff, remember the whole different
> ->sample_format discussion?

Yes, the evsel/evlist abstractions were in part motivated by the
multiple perf_event_attr->sample_type in the same session.

Being 5 weeks AFK was really nice but left me with a rather large
backlog :-)

> /me stomps off and goes do something useful, this userspace is like all
> other userspace.. a steaming pile of shit.

Nah, its all code, no matter what side of the fence.

- Arnaldo