* [GIT PULL 0/4] perf/core improvements and fixes
@ 2011-08-04 14:57 Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 1/4] perf buildid-cache: Zero out buffer of filenames when adding/removing buildid Arnaldo Carvalho de Melo
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-04 14:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core
I still need to comb more for patches sent while I was away,
the ones I checked you already merged, thanks.
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (3):
perf evlist: Introduce 'disable' method
perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables
perf report: Use ui__warning in some more places
Han Pingtian (1):
perf buildid-cache: Zero out buffer of filenames when adding/removing
buildid
tools/perf/builtin-record.c | 19 +------
tools/perf/builtin-report.c | 15 +++---
tools/perf/util/evlist.c | 13 +++++
tools/perf/util/evlist.h | 2 +
tools/perf/util/header.c | 8 ++--
tools/perf/util/python.c | 115 +++++++++++++++++++++++++++++++++++++++++-
6 files changed, 140 insertions(+), 32 deletions(-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] perf buildid-cache: Zero out buffer of filenames when adding/removing buildid
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2011-08-04 14:57 ` Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 2/4] perf evlist: Introduce 'disable' method Arnaldo Carvalho de Melo
` (3 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-04 14:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Han Pingtian, Jiri Olsa, Arnaldo Carvalho de Melo
From: Han Pingtian <phan@redhat.com>
The readlink() function doesn't append a null byte to buf. So we should
zero out buf with zalloc(). Or we'll see sometimes error like this:
[root@intel-s3e36-01]~# /usr/bin/perf buildid-cache -a /lib/modules/2.6.32-130.el6.x86_64/kernel/crypto/twofish_common.ko -v
Adding f64ba8efd5f53c7ad332fc17db1d21de309038e1 /lib/modules/2.6.32-130.el6.x86_64/kernel/crypto/twofish_common.ko: Ok
[root@intel-s3e36-01]~# /usr/bin/perf buildid-cache -r /lib/modules/2.6.32-130.el6.x86_64/kernel/crypto/twofish_common.ko -v
Removing f64ba8efd5f53c7ad332fc17db1d21de309038e1 /lib/modules/2.6.32-130.el6.x86_64/kernel/crypto/twofish_common.ko: FAIL
/lib/modules/2.6.32-130.el6.x86_64/kernel/crypto/twofish_common.ko wasn't in the cache
The change in build_id_cache__add_s() is a defense.
Tested-by: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/20110718031314.GA5802@hpt.nay.redhat.com
Signed-off-by: Han Pingtian <phan@redhat.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index cb2959a..d4f3101 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -189,8 +189,8 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir,
const char *name, bool is_kallsyms)
{
const size_t size = PATH_MAX;
- char *realname, *filename = malloc(size),
- *linkname = malloc(size), *targetname;
+ char *realname, *filename = zalloc(size),
+ *linkname = zalloc(size), *targetname;
int len, err = -1;
if (is_kallsyms) {
@@ -254,8 +254,8 @@ static int build_id_cache__add_b(const u8 *build_id, size_t build_id_size,
int build_id_cache__remove_s(const char *sbuild_id, const char *debugdir)
{
const size_t size = PATH_MAX;
- char *filename = malloc(size),
- *linkname = malloc(size);
+ char *filename = zalloc(size),
+ *linkname = zalloc(size);
int err = -1;
if (filename == NULL || linkname == NULL)
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] perf evlist: Introduce 'disable' method
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 1/4] perf buildid-cache: Zero out buffer of filenames when adding/removing buildid Arnaldo Carvalho de Melo
@ 2011-08-04 14:57 ` Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 3/4] perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables Arnaldo Carvalho de Melo
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-04 14:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Borislav Petkov,
David Ahern, Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Stephane Eranian
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To remove the last case of access to the FD() macro outside the library.
Inspired by a patch by Borislav that moved the FD() macro to util.h, for
namespace concerns I rather preferred to constrain it to ev{sel,list}.c.
Cc: Borislav Petkov <bp@amd64.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-qn893qsstcg366tkucu649qj@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 19 ++-----------------
tools/perf/util/evlist.c | 13 +++++++++++++
tools/perf/util/evlist.h | 2 ++
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 80dc5b7..f6426b4 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -30,8 +30,6 @@
#include <sched.h>
#include <sys/mman.h>
-#define FD(e, x, y) (*(int *)xyarray__entry(e->fd, x, y))
-
enum write_mode_t {
WRITE_FORCE,
WRITE_APPEND
@@ -438,7 +436,6 @@ static void mmap_read_all(void)
static int __cmd_record(int argc, const char **argv)
{
- int i;
struct stat st;
int flags;
int err;
@@ -682,7 +679,6 @@ static int __cmd_record(int argc, const char **argv)
for (;;) {
int hits = samples;
- int thread;
mmap_read_all();
@@ -693,19 +689,8 @@ static int __cmd_record(int argc, const char **argv)
waking++;
}
- if (done) {
- for (i = 0; i < evsel_list->cpus->nr; i++) {
- struct perf_evsel *pos;
-
- list_for_each_entry(pos, &evsel_list->entries, node) {
- for (thread = 0;
- thread < evsel_list->threads->nr;
- thread++)
- ioctl(FD(pos, i, thread),
- PERF_EVENT_IOC_DISABLE);
- }
- }
- }
+ if (done)
+ perf_evlist__disable(evsel_list);
}
if (quiet || signr == SIGUSR1)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index b021ea9..e03e7bc 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -91,6 +91,19 @@ int perf_evlist__add_default(struct perf_evlist *evlist)
return 0;
}
+void perf_evlist__disable(struct perf_evlist *evlist)
+{
+ int cpu, thread;
+ struct perf_evsel *pos;
+
+ for (cpu = 0; cpu < evlist->cpus->nr; cpu++) {
+ list_for_each_entry(pos, &evlist->entries, node) {
+ for (thread = 0; thread < evlist->threads->nr; thread++)
+ ioctl(FD(pos, cpu, thread), PERF_EVENT_IOC_DISABLE);
+ }
+ }
+}
+
int perf_evlist__alloc_pollfd(struct perf_evlist *evlist)
{
int nfds = evlist->cpus->nr * evlist->threads->nr * evlist->nr_entries;
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index b2b8623..ce85ae9 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -53,6 +53,8 @@ int perf_evlist__alloc_mmap(struct perf_evlist *evlist);
int perf_evlist__mmap(struct perf_evlist *evlist, int pages, bool overwrite);
void perf_evlist__munmap(struct perf_evlist *evlist);
+void perf_evlist__disable(struct perf_evlist *evlist);
+
static inline void perf_evlist__set_maps(struct perf_evlist *evlist,
struct cpu_map *cpus,
struct thread_map *threads)
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 1/4] perf buildid-cache: Zero out buffer of filenames when adding/removing buildid Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 2/4] perf evlist: Introduce 'disable' method Arnaldo Carvalho de Melo
@ 2011-08-04 14:57 ` Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 4/4] perf report: Use ui__warning in some more places Arnaldo Carvalho de Melo
2011-08-05 8:36 ` [GIT PULL 0/4] perf/core improvements and fixes Ingo Molnar
4 siblings, 0 replies; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-04 14:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Stephane Eranian
From: Arnaldo Carvalho de Melo <acme@redhat.com>
So those friggin "spurious" PERF_RECORD_MMAP events were actually a
brain fart copy'n'paste error in the python binding, doh. I.e. they
weren't MMAPs, just SAMPLEs.
Fix it by providing routines for these events instead of using the MMAP
ones.
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-b0rc8y5jd03f9f11kftodvkm@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/python.c | 115 ++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 112 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 8e0b5a3..cbc8f21 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -187,16 +187,119 @@ static PyTypeObject pyrf_throttle_event__type = {
.tp_repr = (reprfunc)pyrf_throttle_event__repr,
};
+static char pyrf_lost_event__doc[] = PyDoc_STR("perf lost event object.");
+
+static PyMemberDef pyrf_lost_event__members[] = {
+ sample_members
+ member_def(lost_event, id, T_ULONGLONG, "event id"),
+ member_def(lost_event, lost, T_ULONGLONG, "number of lost events"),
+ { .name = NULL, },
+};
+
+static PyObject *pyrf_lost_event__repr(struct pyrf_event *pevent)
+{
+ PyObject *ret;
+ char *s;
+
+ if (asprintf(&s, "{ type: lost, id: %#" PRIx64 ", "
+ "lost: %#" PRIx64 " }",
+ pevent->event.lost.id, pevent->event.lost.lost) < 0) {
+ ret = PyErr_NoMemory();
+ } else {
+ ret = PyString_FromString(s);
+ free(s);
+ }
+ return ret;
+}
+
+static PyTypeObject pyrf_lost_event__type = {
+ PyVarObject_HEAD_INIT(NULL, 0)
+ .tp_name = "perf.lost_event",
+ .tp_basicsize = sizeof(struct pyrf_event),
+ .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+ .tp_doc = pyrf_lost_event__doc,
+ .tp_members = pyrf_lost_event__members,
+ .tp_repr = (reprfunc)pyrf_lost_event__repr,
+};
+
+static char pyrf_read_event__doc[] = PyDoc_STR("perf read event object.");
+
+static PyMemberDef pyrf_read_event__members[] = {
+ sample_members
+ member_def(read_event, pid, T_UINT, "event pid"),
+ member_def(read_event, tid, T_UINT, "event tid"),
+ { .name = NULL, },
+};
+
+static PyObject *pyrf_read_event__repr(struct pyrf_event *pevent)
+{
+ return PyString_FromFormat("{ type: read, pid: %u, tid: %u }",
+ pevent->event.read.pid,
+ pevent->event.read.tid);
+ /*
+ * FIXME: return the array of read values,
+ * making this method useful ;-)
+ */
+}
+
+static PyTypeObject pyrf_read_event__type = {
+ PyVarObject_HEAD_INIT(NULL, 0)
+ .tp_name = "perf.read_event",
+ .tp_basicsize = sizeof(struct pyrf_event),
+ .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+ .tp_doc = pyrf_read_event__doc,
+ .tp_members = pyrf_read_event__members,
+ .tp_repr = (reprfunc)pyrf_read_event__repr,
+};
+
+static char pyrf_sample_event__doc[] = PyDoc_STR("perf sample event object.");
+
+static PyMemberDef pyrf_sample_event__members[] = {
+ sample_members
+ member_def(perf_event_header, type, T_UINT, "event type"),
+ { .name = NULL, },
+};
+
+static PyObject *pyrf_sample_event__repr(struct pyrf_event *pevent)
+{
+ PyObject *ret;
+ char *s;
+
+ if (asprintf(&s, "{ type: sample }") < 0) {
+ ret = PyErr_NoMemory();
+ } else {
+ ret = PyString_FromString(s);
+ free(s);
+ }
+ return ret;
+}
+
+static PyTypeObject pyrf_sample_event__type = {
+ PyVarObject_HEAD_INIT(NULL, 0)
+ .tp_name = "perf.sample_event",
+ .tp_basicsize = sizeof(struct pyrf_event),
+ .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+ .tp_doc = pyrf_sample_event__doc,
+ .tp_members = pyrf_sample_event__members,
+ .tp_repr = (reprfunc)pyrf_sample_event__repr,
+};
+
static int pyrf_event__setup_types(void)
{
int err;
pyrf_mmap_event__type.tp_new =
pyrf_task_event__type.tp_new =
pyrf_comm_event__type.tp_new =
+ pyrf_lost_event__type.tp_new =
+ pyrf_read_event__type.tp_new =
+ pyrf_sample_event__type.tp_new =
pyrf_throttle_event__type.tp_new = PyType_GenericNew;
err = PyType_Ready(&pyrf_mmap_event__type);
if (err < 0)
goto out;
+ err = PyType_Ready(&pyrf_lost_event__type);
+ if (err < 0)
+ goto out;
err = PyType_Ready(&pyrf_task_event__type);
if (err < 0)
goto out;
@@ -206,20 +309,26 @@ static int pyrf_event__setup_types(void)
err = PyType_Ready(&pyrf_throttle_event__type);
if (err < 0)
goto out;
+ err = PyType_Ready(&pyrf_read_event__type);
+ if (err < 0)
+ goto out;
+ err = PyType_Ready(&pyrf_sample_event__type);
+ if (err < 0)
+ goto out;
out:
return err;
}
static PyTypeObject *pyrf_event__type[] = {
[PERF_RECORD_MMAP] = &pyrf_mmap_event__type,
- [PERF_RECORD_LOST] = &pyrf_mmap_event__type,
+ [PERF_RECORD_LOST] = &pyrf_lost_event__type,
[PERF_RECORD_COMM] = &pyrf_comm_event__type,
[PERF_RECORD_EXIT] = &pyrf_task_event__type,
[PERF_RECORD_THROTTLE] = &pyrf_throttle_event__type,
[PERF_RECORD_UNTHROTTLE] = &pyrf_throttle_event__type,
[PERF_RECORD_FORK] = &pyrf_task_event__type,
- [PERF_RECORD_READ] = &pyrf_mmap_event__type,
- [PERF_RECORD_SAMPLE] = &pyrf_mmap_event__type,
+ [PERF_RECORD_READ] = &pyrf_read_event__type,
+ [PERF_RECORD_SAMPLE] = &pyrf_sample_event__type,
};
static PyObject *pyrf_event__new(union perf_event *event)
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] perf report: Use ui__warning in some more places
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2011-08-04 14:57 ` [PATCH 3/4] perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables Arnaldo Carvalho de Melo
@ 2011-08-04 14:57 ` Arnaldo Carvalho de Melo
2011-08-05 8:36 ` [GIT PULL 0/4] perf/core improvements and fixes Ingo Molnar
4 siblings, 0 replies; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-04 14:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Arun Sharma, David Ahern,
Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Sam Liao, Stephane Eranian
From: Arnaldo Carvalho de Melo <acme@redhat.com>
So that we get a proper warning in the TUI in cases like:
$ perf report --stdio -g fractal,0.5,caller --sort pid
Selected -g but no callchain data. Did you call 'perf record' without -g?
$
The --stdio case is ok because it uses fprintf, ui__warning is needed to
figure out if --stdio or --tui is being used.
Cc: Arun Sharma <asharma@fb.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sam Liao <phyomh@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-ag9fz2wd17mbbfjsbznq1wms@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 15 +++++++--------
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index f854efd..d7ff277 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -162,23 +162,22 @@ static int perf_session__setup_sample_type(struct perf_session *self)
{
if (!(self->sample_type & PERF_SAMPLE_CALLCHAIN)) {
if (sort__has_parent) {
- fprintf(stderr, "selected --sort parent, but no"
- " callchain data. Did you call"
- " perf record without -g?\n");
+ ui__warning("Selected --sort parent, but no "
+ "callchain data. Did you call "
+ "'perf record' without -g?\n");
return -EINVAL;
}
if (symbol_conf.use_callchain) {
- fprintf(stderr, "selected -g but no callchain data."
- " Did you call perf record without"
- " -g?\n");
+ ui__warning("Selected -g but no callchain data. Did "
+ "you call 'perf record' without -g?\n");
return -1;
}
} else if (!dont_use_callchains && callchain_param.mode != CHAIN_NONE &&
!symbol_conf.use_callchain) {
symbol_conf.use_callchain = true;
if (callchain_register_param(&callchain_param) < 0) {
- fprintf(stderr, "Can't register callchain"
- " params\n");
+ ui__warning("Can't register callchain "
+ "params.\n");
return -EINVAL;
}
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [GIT PULL 0/4] perf/core improvements and fixes
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2011-08-04 14:57 ` [PATCH 4/4] perf report: Use ui__warning in some more places Arnaldo Carvalho de Melo
@ 2011-08-05 8:36 ` Ingo Molnar
4 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2011-08-05 8:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Peter Zijlstra,
Thomas Gleixner
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core
>
> I still need to comb more for patches sent while I was away,
> the ones I checked you already merged, thanks.
>
> Regards,
>
> - Arnaldo
>
>
> Arnaldo Carvalho de Melo (3):
> perf evlist: Introduce 'disable' method
> perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables
> perf report: Use ui__warning in some more places
>
> Han Pingtian (1):
> perf buildid-cache: Zero out buffer of filenames when adding/removing
> buildid
>
> tools/perf/builtin-record.c | 19 +------
> tools/perf/builtin-report.c | 15 +++---
> tools/perf/util/evlist.c | 13 +++++
> tools/perf/util/evlist.h | 2 +
> tools/perf/util/header.c | 8 ++--
> tools/perf/util/python.c | 115 +++++++++++++++++++++++++++++++++++++++++-
> 6 files changed, 140 insertions(+), 32 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [GIT PULL 0/4] perf/core improvements and fixes
@ 2011-10-20 13:05 Arnaldo Carvalho de Melo
2011-10-23 10:59 ` Ingo Molnar
0 siblings, 1 reply; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-10-20 13:05 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, arnaldo.melo
Hi Ingo,
Please consider pulling from:
git://github.com/acmel/linux.git perf/core
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (4):
perf hists browser: Honour symbol_conf.show_{nr_samples,total_period}
perf hists: Don't decay total_period for filtered entries
perf hists: Don't consider filtered entries when calculating column widths
perf hists browser: Elide DSO column when it is set to just one DSO, ditto for threads
tools/perf/util/hist.c | 14 ++++++++++----
tools/perf/util/sort.c | 4 +++-
tools/perf/util/ui/browsers/hists.c | 14 ++++++++++++++
3 files changed, 27 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [GIT PULL 0/4] perf/core improvements and fixes
2011-10-20 13:05 Arnaldo Carvalho de Melo
@ 2011-10-23 10:59 ` Ingo Molnar
0 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2011-10-23 10:59 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, arnaldo.melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling from:
>
> git://github.com/acmel/linux.git perf/core
>
> Regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (4):
> perf hists browser: Honour symbol_conf.show_{nr_samples,total_period}
> perf hists: Don't decay total_period for filtered entries
> perf hists: Don't consider filtered entries when calculating column widths
> perf hists browser: Elide DSO column when it is set to just one DSO, ditto for threads
>
> tools/perf/util/hist.c | 14 ++++++++++----
> tools/perf/util/sort.c | 4 +++-
> tools/perf/util/ui/browsers/hists.c | 14 ++++++++++++++
> 3 files changed, 27 insertions(+), 5 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [GIT PULL 0/4] perf/core improvements and fixes
@ 2014-07-10 21:06 Jiri Olsa
2014-07-16 11:48 ` Ingo Molnar
0 siblings, 1 reply; 14+ messages in thread
From: Jiri Olsa @ 2014-07-10 21:06 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stanislav Fomichev, Jiri Olsa
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 8b5b584daf3b92fc5cdc83919e64231817d2f5a7:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-07-05 11:29:32 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to d243144af0b52fc5164a0823194f29a5979e236c:
perf timechart: Add more options to IO mode (2014-07-10 00:22:54 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Add IO mode into timechart command (Stanislav Fomichev)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Stanislav Fomichev (4):
perf timechart: Fix rendering in Firefox
perf timechart: Implement IO mode
perf timechart: Conditionally update start_time on fork
perf timechart: Add more options to IO mode
tools/perf/Documentation/perf-timechart.txt | 38 +-
tools/perf/builtin-timechart.c | 693 +++++++++++++++++++++++++++-
tools/perf/util/svghelper.c | 168 +++++--
tools/perf/util/svghelper.h | 6 +-
4 files changed, 845 insertions(+), 60 deletions(-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [GIT PULL 0/4] perf/core improvements and fixes
2014-07-10 21:06 Jiri Olsa
@ 2014-07-16 11:48 ` Ingo Molnar
0 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2014-07-16 11:48 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stanislav Fomichev, Thomas Gleixner
* Jiri Olsa <jolsa@kernel.org> wrote:
> hi Ingo,
> please consider pulling
>
> thanks,
> jirka
>
>
> The following changes since commit 8b5b584daf3b92fc5cdc83919e64231817d2f5a7:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-07-05 11:29:32 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
>
> for you to fetch changes up to d243144af0b52fc5164a0823194f29a5979e236c:
>
> perf timechart: Add more options to IO mode (2014-07-10 00:22:54 +0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Add IO mode into timechart command (Stanislav Fomichev)
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> ----------------------------------------------------------------
> Stanislav Fomichev (4):
> perf timechart: Fix rendering in Firefox
> perf timechart: Implement IO mode
> perf timechart: Conditionally update start_time on fork
> perf timechart: Add more options to IO mode
>
> tools/perf/Documentation/perf-timechart.txt | 38 +-
> tools/perf/builtin-timechart.c | 693 +++++++++++++++++++++++++++-
> tools/perf/util/svghelper.c | 168 +++++--
> tools/perf/util/svghelper.h | 6 +-
> 4 files changed, 845 insertions(+), 60 deletions(-)
Pulled, thanks a lot Jiri!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [GIT PULL 0/4] perf/core improvements and fixes
@ 2015-10-20 20:25 Arnaldo Carvalho de Melo
2015-10-21 8:11 ` Ingo Molnar
0 siblings, 1 reply; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-20 20:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, David Ahern, Jiri Olsa, Kan Liang,
Masami Hiramatsu, Namhyung Kim, Paolo Bonzini, Paul Mackerras,
Peter Zijlstra, Steven Rostedt, Wang Nan, Yunlong Song,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:
perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to bab84928dfadf8cba4d3fadcea0890de4da37be8:
perf evsel: Print branch filter state with -vv (2015-10-20 15:54:21 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Print branch filter state with verbose mode (Andi Kleen)
- Fix core dump caused by per-socket/core system-wide stat (Kan Liang)
- Update libtraceevent KVM plugin (Paolo Bonzini)
Developer stuff:
- Add fixdep to 'tools/build' .gitignore (Yunlong Song)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf evsel: Print branch filter state with -vv
Kan Liang (1):
perf cpu_map: Fix core dump caused by per-socket/core system-wide stat
Paolo Bonzini (1):
tools lib traceevent: update KVM plugin
Yunlong Song (1):
perf build: Add fixdep to .gitignore
tools/build/.gitignore | 1 +
tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
tools/perf/util/cpumap.c | 2 +-
tools/perf/util/evsel.c | 1 +
4 files changed, 20 insertions(+), 9 deletions(-)
create mode 100644 tools/build/.gitignore
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [GIT PULL 0/4] perf/core improvements and fixes
2015-10-20 20:25 Arnaldo Carvalho de Melo
@ 2015-10-21 8:11 ` Ingo Molnar
0 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2015-10-21 8:11 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
David Ahern, Jiri Olsa, Kan Liang, Masami Hiramatsu, Namhyung Kim,
Paolo Bonzini, Paul Mackerras, Peter Zijlstra, Steven Rostedt,
Wang Nan, Yunlong Song, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:
>
> perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to bab84928dfadf8cba4d3fadcea0890de4da37be8:
>
> perf evsel: Print branch filter state with -vv (2015-10-20 15:54:21 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Print branch filter state with verbose mode (Andi Kleen)
>
> - Fix core dump caused by per-socket/core system-wide stat (Kan Liang)
>
> - Update libtraceevent KVM plugin (Paolo Bonzini)
>
> Developer stuff:
>
> - Add fixdep to 'tools/build' .gitignore (Yunlong Song)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf evsel: Print branch filter state with -vv
>
> Kan Liang (1):
> perf cpu_map: Fix core dump caused by per-socket/core system-wide stat
>
> Paolo Bonzini (1):
> tools lib traceevent: update KVM plugin
>
> Yunlong Song (1):
> perf build: Add fixdep to .gitignore
>
> tools/build/.gitignore | 1 +
> tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
> tools/perf/util/cpumap.c | 2 +-
> tools/perf/util/evsel.c | 1 +
> 4 files changed, 20 insertions(+), 9 deletions(-)
> create mode 100644 tools/build/.gitignore
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
* [GIT PULL 0/4] perf/core improvements and fixes
@ 2015-11-25 19:46 Arnaldo Carvalho de Melo
2015-11-26 8:15 ` Ingo Molnar
0 siblings, 1 reply; 14+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-11-25 19:46 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, David Ahern, Jiri Olsa, Masami Hiramatsu,
Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama,
Steven Rostedt, Wang Nan, Zefan Li
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi,
Please consider pulling, this is on top of my previous
perf-core-for-mingo pull request.
- Arnaldo
The following changes since commit 646a6e846c4dc3812c614fd061603b6db5b8d380:
perf callchain: Add missing parent_val initialization (2015-11-23 18:31:25 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
for you to fetch changes up to d8ad6a15cc3a364de6c8010378adc3fb06ce3ff1:
tools lib bpf: Don't do a feature check when cleaning (2015-11-25 16:38:13 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix to free temporal Dwarf_Frame correctly in 'perf probe', fixing a
regression introduced in perf/core that prevented, at least, adding
an uprobe collecting function parameter values (Masami Hiramatsu)
- Fix output of %llu for 64 bit values read on 32 bit machines in
libtraceevent (Steven Rostedt)
Developer visible:
- Clean CFLAGS and LDFLAGS for fixdep in tools/build (Wang Nan)
- Don't do a feature check when cleaning tools/lib/bpf (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Masami Hiramatsu (1):
perf probe: Fix to free temporal Dwarf_Frame correctly
Steven Rostedt (1):
tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines
Wang Nan (2):
tools build: Clean CFLAGS and LDFLAGS for fixdep
tools lib bpf: Don't do a feature check when cleaning
tools/build/Makefile.include | 2 +-
tools/lib/bpf/Makefile | 10 ++++++++++
tools/lib/traceevent/event-parse.c | 5 ++---
tools/perf/util/probe-finder.c | 13 ++++++-------
4 files changed, 19 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [GIT PULL 0/4] perf/core improvements and fixes
2015-11-25 19:46 Arnaldo Carvalho de Melo
@ 2015-11-26 8:15 ` Ingo Molnar
0 siblings, 0 replies; 14+ messages in thread
From: Ingo Molnar @ 2015-11-26 8:15 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, David Ahern, Jiri Olsa, Masami Hiramatsu,
Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama,
Steven Rostedt, Wang Nan, Zefan Li
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi,
>
> Please consider pulling, this is on top of my previous
> perf-core-for-mingo pull request.
>
> - Arnaldo
>
> The following changes since commit 646a6e846c4dc3812c614fd061603b6db5b8d380:
>
> perf callchain: Add missing parent_val initialization (2015-11-23 18:31:25 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
>
> for you to fetch changes up to d8ad6a15cc3a364de6c8010378adc3fb06ce3ff1:
>
> tools lib bpf: Don't do a feature check when cleaning (2015-11-25 16:38:13 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix to free temporal Dwarf_Frame correctly in 'perf probe', fixing a
> regression introduced in perf/core that prevented, at least, adding
> an uprobe collecting function parameter values (Masami Hiramatsu)
>
> - Fix output of %llu for 64 bit values read on 32 bit machines in
> libtraceevent (Steven Rostedt)
>
> Developer visible:
>
> - Clean CFLAGS and LDFLAGS for fixdep in tools/build (Wang Nan)
>
> - Don't do a feature check when cleaning tools/lib/bpf (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Masami Hiramatsu (1):
> perf probe: Fix to free temporal Dwarf_Frame correctly
>
> Steven Rostedt (1):
> tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines
>
> Wang Nan (2):
> tools build: Clean CFLAGS and LDFLAGS for fixdep
> tools lib bpf: Don't do a feature check when cleaning
>
> tools/build/Makefile.include | 2 +-
> tools/lib/bpf/Makefile | 10 ++++++++++
> tools/lib/traceevent/event-parse.c | 5 ++---
> tools/perf/util/probe-finder.c | 13 ++++++-------
> 4 files changed, 19 insertions(+), 11 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-11-26 8:15 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 14:57 [GIT PULL 0/4] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 1/4] perf buildid-cache: Zero out buffer of filenames when adding/removing buildid Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 2/4] perf evlist: Introduce 'disable' method Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 3/4] perf python: Add PERF_RECORD_{LOST,READ,SAMPLE} routine tables Arnaldo Carvalho de Melo
2011-08-04 14:57 ` [PATCH 4/4] perf report: Use ui__warning in some more places Arnaldo Carvalho de Melo
2011-08-05 8:36 ` [GIT PULL 0/4] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 13:05 Arnaldo Carvalho de Melo
2011-10-23 10:59 ` Ingo Molnar
2014-07-10 21:06 Jiri Olsa
2014-07-16 11:48 ` Ingo Molnar
2015-10-20 20:25 Arnaldo Carvalho de Melo
2015-10-21 8:11 ` Ingo Molnar
2015-11-25 19:46 Arnaldo Carvalho de Melo
2015-11-26 8:15 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).