From: Thomas Meyer <thomas@m3y3r.de>
To: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] n2_crypto: Fix a get/put_cpu() imbalance
Date: Sat, 06 Aug 2011 10:26:25 +0200 [thread overview]
Message-ID: <1312619188.5589.27.camel@localhost.localdomain> (raw)
From: Thomas Meyer <thomas@m3y3r.de>
Fix a get/put_cpu() imbalance in the error case when qp == NULL
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index d0183ddb..6683b58 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1006,9 +1006,8 @@ static int n2_do_ecb(struct ablkcipher_request *req, bool encrypt)
spin_unlock_irqrestore(&qp->lock, flags);
- put_cpu();
-
out:
+ put_cpu();
n2_chunk_complete(req, NULL);
return err;
}
@@ -1096,9 +1095,8 @@ static int n2_do_chaining(struct ablkcipher_request *req, bool encrypt)
spin_unlock_irqrestore(&qp->lock, flags);
- put_cpu();
-
out:
+ put_cpu();
n2_chunk_complete(req, err ? NULL : final_iv_addr);
return err;
}
next reply other threads:[~2011-08-06 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 8:26 Thomas Meyer [this message]
2011-08-08 5:55 ` [PATCH] n2_crypto: Fix a get/put_cpu() imbalance David Miller
2011-08-10 10:59 ` Herbert Xu
2011-08-13 7:59 ` Thomas Meyer
2011-08-15 7:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312619188.5589.27.camel@localhost.localdomain \
--to=thomas@m3y3r.de \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox