From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792Ab1HHOcb (ORCPT ); Mon, 8 Aug 2011 10:32:31 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50575 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455Ab1HHOc3 convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2011 10:32:29 -0400 Subject: Re: [PATCH 2/5] writeback: dirty position control From: Peter Zijlstra To: Wu Fengguang Cc: "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , linux-mm , LKML Date: Mon, 08 Aug 2011 16:31:49 +0200 In-Reply-To: <20110808141128.GA22080@localhost> References: <20110806084447.388624428@intel.com> <20110806094526.733282037@intel.com> <1312811193.10488.33.camel@twins> <20110808141128.GA22080@localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.0.2- Message-ID: <1312813909.10488.38.camel@twins> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-08-08 at 22:11 +0800, Wu Fengguang wrote: > It's actually dead code because (origin < limit) should never happen. > I feel so good being able to drop 5 more lines of code :) OK, but that leaves me trying to figure out what origin is, and why its 4 * thresh. I'm having a horrible time understanding this stuff.