public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-i2c@vger.kernel.org
Subject: Re: dynamic-debug not built into scx200_acb, scx200_i2c
Date: Wed, 10 Aug 2011 16:50:16 -0700	[thread overview]
Message-ID: <1313020216.11924.129.camel@Joe-Laptop> (raw)
In-Reply-To: <CAJfuBxwq3xw3MZU01rwzg0NAnnxNoLrC2x0QXnj+2pD-6gkR4g@mail.gmail.com>

On Wed, 2011-08-10 at 15:06 -0600, Jim Cromie wrote:
> scx200_acb has several pr_debugs, but theyre not available via dynamic-debug
> 
> Ive been unable to figure out why.
> Any ideas ?

-DDEBUG forces pr_debug to be output and doesn't
allow dynamic_debug for those outputs.

from drivers/i2c/busses/Makefile:

ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG

from printk.h:

/* If you are writing a driver, please use dev_dbg instead */
#if defined(DEBUG)
#define pr_debug(fmt, ...) \
	printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
#elif defined(CONFIG_DYNAMIC_DEBUG)
/* dynamic_pr_debug() uses pr_fmt() internally so we don't need it here */
#define pr_debug(fmt, ...) \
	dynamic_pr_debug(fmt, ##__VA_ARGS__)




  reply	other threads:[~2011-08-10 23:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 21:06 dynamic-debug not built into scx200_acb, scx200_i2c Jim Cromie
2011-08-10 23:50 ` Joe Perches [this message]
2011-08-11  0:01   ` RFC: Use dynamic-debug with pr_debug when -DDEBUG is set Joe Perches
2011-08-11  0:20     ` Jason Baron
2011-08-11  1:03       ` Joe Perches
2011-08-11  5:44         ` Jim Cromie
2011-08-11  6:06           ` Joe Perches
2011-08-10 23:52 ` dynamic-debug not built into scx200_acb, scx200_i2c Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313020216.11924.129.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox