From: Peter Zijlstra <peterz@infradead.org>
To: Alex Neronskiy <zakmagnus@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Don Zickus <dzickus@redhat.com>,
Mandeep Singh Baines <msb@chromium.org>,
Alex Neronskiy <zakmagnus@chromium.com>
Subject: Re: [PATCH v6 2/2] Output stall data in debugfs
Date: Thu, 11 Aug 2011 21:13:08 +0200 [thread overview]
Message-ID: <1313089988.8491.15.camel@twins> (raw)
In-Reply-To: <1312999364-21104-2-git-send-email-zakmagnus@chromium.org>
On Wed, 2011-08-10 at 11:02 -0700, Alex Neronskiy wrote:
> +static unsigned long softstall_trace_entries[STALL_MAX_TRACE_DEPTH * 2];
> +static struct stack_trace softstall_traces[2];
> +static spinlock_t softstall_locks[2];
> +static DEFINE_SPINLOCK(softstall_read_lock);
> +static DEFINE_SPINLOCK(softstall_write_lock);
> +static int soft_read_ind;
>
> static DEFINE_PER_CPU(unsigned long, watchdog_touch_ts);
> static DEFINE_PER_CPU(struct task_struct *, softlockup_watchdog);
> @@ -46,7 +67,12 @@ static DEFINE_PER_CPU(unsigned long, hrtimer_interrupts_missed);
> static DEFINE_PER_CPU(struct perf_event *, watchdog_ev);
>
> unsigned long worst_hardstall;
> +static unsigned long hardstall_trace_entries[STALL_MAX_TRACE_DEPTH * 2];
> +static struct stack_trace hardstall_traces[2];
> +static spinlock_t hardstall_locks[2];
> +static DEFINE_SPINLOCK(hardstall_read_lock);
> +static DEFINE_SPINLOCK(hardstall_write_lock);
> +static int hard_read_ind;
You really gotta love typing, but the rest of us know to use structures
for this.
next prev parent reply other threads:[~2011-08-11 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 18:02 [PATCH v6 1/2] Track hard and soft "short lockups" or "stalls." Alex Neronskiy
2011-08-10 18:02 ` [PATCH v6 2/2] Output stall data in debugfs Alex Neronskiy
2011-08-11 18:48 ` Andi Kleen
2011-08-11 19:04 ` Don Zickus
2011-08-11 21:05 ` Andi Kleen
2011-08-11 19:13 ` Peter Zijlstra [this message]
2011-08-11 19:35 ` Peter Zijlstra
2011-08-11 20:10 ` Alex Neronskiy
2011-08-11 20:23 ` Peter Zijlstra
2011-08-11 20:31 ` Alex Neronskiy
2011-08-11 21:17 ` Peter Zijlstra
2011-08-11 22:02 ` Alex Neronskiy
2011-08-11 23:00 ` Mandeep Singh Baines
2011-08-12 12:14 ` Peter Zijlstra
2011-08-16 19:32 ` Mandeep Singh Baines
2011-08-12 9:06 ` Ingo Molnar
2011-08-12 19:46 ` Alex Neronskiy
2011-08-11 19:43 ` Peter Zijlstra
2011-08-11 19:51 ` Alex Neronskiy
2011-08-11 19:57 ` Peter Zijlstra
2011-08-11 19:09 ` [PATCH v6 1/2] Track hard and soft "short lockups" or "stalls." Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313089988.8491.15.camel@twins \
--to=peterz@infradead.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=msb@chromium.org \
--cc=zakmagnus@chromium.com \
--cc=zakmagnus@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox