public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Todd Poynor <toddpoynor@google.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: twl: Fix registration vs. init order
Date: Fri, 12 Aug 2011 16:36:52 -0700	[thread overview]
Message-ID: <1313192212.2970.45.camel@work-vm> (raw)
In-Reply-To: <1313032836-347-1-git-send-email-toddpoynor@google.com>

On Wed, 2011-08-10 at 20:20 -0700, Todd Poynor wrote:
> Only register as an RTC device after the hardware has been
> successfully initialized.  The RTC class driver will call
> back to this driver to read a pending alarm, and other
> drivers watching for new devices on the RTC class may
> read the RTC time upon registration.  Such access might
> occur while the RTC is stopped, prior to clearing
> pending alarms, etc.
> 
> The new ordering also avoids leaving the platform
> device drvdata set to an unregistered struct rtc_device *
> on probe errors.
> 
> Signed-off-by: Todd Poynor <toddpoynor@google.com>

Thanks! Queued.
-john


      reply	other threads:[~2011-08-12 23:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11  3:20 [PATCH] rtc: twl: Fix registration vs. init order Todd Poynor
2011-08-12 23:36 ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313192212.2970.45.camel@work-vm \
    --to=john.stultz@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox