From: Thomas Meyer <thomas@m3y3r.de>
To: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] staging: rts_pstor: dont cast void* from kmalloc()
Date: Sat, 13 Aug 2011 16:14:03 +0200 [thread overview]
Message-ID: <1313244847.16820.43.camel@localhost.localdomain> (raw)
From: Thomas Meyer <thomas@m3y3r.de>
Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
--- a/drivers/staging/rts_pstor/sd.c 2011-07-28 15:32:18.233251740 +0200
+++ b/drivers/staging/rts_pstor/sd.c 2011-08-01 19:57:13.347362265 +0200
@@ -4139,7 +4139,7 @@ int sd_execute_read_data(struct scsi_cmn
cmd[3] = srb->cmnd[5];
cmd[4] = srb->cmnd[6];
- buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+ buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR);
}
@@ -4385,7 +4385,7 @@ int sd_execute_write_data(struct scsi_cm
u16 i;
u8 *buf;
- buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+ buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR);
}
next reply other threads:[~2011-08-13 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 14:14 Thomas Meyer [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-13 9:28 [PATCH] Staging: rts_pstor: dont cast void* from kmalloc() Thomas Meyer
2011-08-13 9:27 [PATCH] staging: " Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313244847.16820.43.camel@localhost.localdomain \
--to=thomas@m3y3r.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox