From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, Don Zickus <dzickus@redhat.com>,
Matthew Garrett <mjg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: pstore: change mutex locking to spin_locks
Date: Wed, 17 Aug 2011 23:47:59 +0200 [thread overview]
Message-ID: <1313617679.2212.4.camel@laptop> (raw)
In-Reply-To: <20110817142225.8645fff7.akpm@linux-foundation.org>
On Wed, 2011-08-17 at 14:22 -0700, Andrew Morton wrote:
> It's still bad if lockdep is enabled. See
> kernel/lockdep.c:lock_acquire() and lock_release(). They aren't
> NMI-safe.
Good thing nmi_enter() does lockdep_disable() and makes lock_acquire()
bail on if (current->lockdep_recursion).
Still the fact that pstore needs locks from NMI context (let alone tried
to use a mutex) makes one think one should avoid it like the plague.
next prev parent reply other threads:[~2011-08-17 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 17:54 pstore: change mutex locking to spin_locks Luck, Tony
2011-08-12 17:59 ` Matthew Garrett
2011-08-17 21:22 ` Andrew Morton
2011-08-17 21:47 ` Peter Zijlstra [this message]
2011-08-18 13:04 ` Don Zickus
2011-08-18 15:26 ` Peter Zijlstra
2011-08-18 12:58 ` Don Zickus
2011-08-18 14:37 ` Peter Zijlstra
2011-08-18 16:33 ` Luck, Tony
2011-08-18 17:25 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313617679.2212.4.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox