[PATCH] PM: pm_clock.h needs to include linux/notifier.h

[PATCH] PM: pm_clock.h needs to include linux/notifier.h

[Axel Lin]

This patch fixes below build error:

  CC      drivers/base/power/clock_ops.o
In file included from drivers/base/power/clock_ops.c:13:
include/linux/pm_clock.h:15: error: field 'nb' has incomplete type
drivers/base/power/clock_ops.c: In function 'pm_clk_notify':
drivers/base/power/clock_ops.c:437: warning: type defaults to 'int' in declaration of '__mptr'
drivers/base/power/clock_ops.c:437: warning: initialization from incompatible pointer type
make[3]: *** [drivers/base/power/clock_ops.o] Error 1
make[2]: *** [drivers/base/power] Error 2
make[1]: *** [drivers/base] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against linux-next next-20110818.
Axel

 include/linux/pm_clock.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pm_clock.h b/include/linux/pm_clock.h
index f888013..8348866 100644
--- a/include/linux/pm_clock.h
+++ b/include/linux/pm_clock.h
@@ -10,6 +10,7 @@
 #define _LINUX_PM_CLOCK_H
 
 #include <linux/device.h>
+#include <linux/notifier.h>
 
 struct pm_clk_notifier_block {
 	struct notifier_block nb;
-- 
1.7.4.1

Re: [PATCH] PM: pm_clock.h needs to include linux/notifier.h

[Rafael J. Wysocki]

On Friday, August 19, 2011, Axel Lin wrote:
> This patch fixes below build error:

This problem should be fixed already in the linux-pm tree.

Thanks,
Rafael


>   CC      drivers/base/power/clock_ops.o
> In file included from drivers/base/power/clock_ops.c:13:
> include/linux/pm_clock.h:15: error: field 'nb' has incomplete type
> drivers/base/power/clock_ops.c: In function 'pm_clk_notify':
> drivers/base/power/clock_ops.c:437: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/base/power/clock_ops.c:437: warning: initialization from incompatible pointer type
> make[3]: *** [drivers/base/power/clock_ops.o] Error 1
> make[2]: *** [drivers/base/power] Error 2
> make[1]: *** [drivers/base] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next next-20110818.
> Axel
> 
>  include/linux/pm_clock.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pm_clock.h b/include/linux/pm_clock.h
> index f888013..8348866 100644
> --- a/include/linux/pm_clock.h
> +++ b/include/linux/pm_clock.h
> @@ -10,6 +10,7 @@
>  #define _LINUX_PM_CLOCK_H
>  
>  #include <linux/device.h>
> +#include <linux/notifier.h>
>  
>  struct pm_clk_notifier_block {
>  	struct notifier_block nb;
>