From: Deepthy Ravi <deepthy.ravi@ti.com>
To: <mchehab@infradead.org>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <linux-omap@vger.kernel.org>, Vaibhav Hiremath <hvaibhav@ti.com>,
Deepthy Ravi <deepthy.ravi@ti.com>
Subject: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and
Date: Fri, 19 Aug 2011 19:18:45 +0530 [thread overview]
Message-ID: <1313761725-6614-1-git-send-email-deepthy.ravi@ti.com> (raw)
From: Vaibhav Hiremath <hvaibhav@ti.com>
Fix the build break caused when CONFIG_MEDIA_CONTROLLER
option is disabled and if any sensor driver has to be used
between MC and non MC framework compatible devices.
For example,if tvp514x video decoder driver migrated to
MC framework is being built without CONFIG_MEDIA_CONTROLLER
option enabled, the following error messages will result.
drivers/built-in.o: In function `tvp514x_remove':
drivers/media/video/tvp514x.c:1285: undefined reference to
`media_entity_cleanup'
drivers/built-in.o: In function `tvp514x_probe':
drivers/media/video/tvp514x.c:1237: undefined reference to
`media_entity_init'
The file containing definitions of media_entity_init and
media_entity_cleanup functions will not be built if that
config option is disabled. And this is corrected by
defining two dummy functions.
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com>
---
include/media/media-entity.h | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index cd8bca6..c90916e 100644
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
@@ -121,9 +121,18 @@ struct media_entity_graph {
int top;
};
+#ifdef CONFIG_MEDIA_CONTROLLER
int media_entity_init(struct media_entity *entity, u16 num_pads,
struct media_pad *pads, u16 extra_links);
void media_entity_cleanup(struct media_entity *entity);
+#else
+static inline int media_entity_init(struct media_entity *entity, u16 num_pads,
+ struct media_pad *pads, u16 extra_links)
+{
+ return 0;
+}
+static inline void media_entity_cleanup(struct media_entity *entity) {}
+#endif
int media_entity_create_link(struct media_entity *source, u16 source_pad,
struct media_entity *sink, u16 sink_pad, u32 flags);
--
1.7.0.4
next reply other threads:[~2011-08-19 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 13:48 Deepthy Ravi [this message]
2011-08-24 10:17 ` [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and Laurent Pinchart
2011-08-24 11:21 ` Ravi, Deepthy
2011-08-24 11:29 ` Laurent Pinchart
2011-08-24 12:19 ` Hiremath, Vaibhav
2011-08-24 12:55 ` Andy Shevchenko
2011-08-24 13:19 ` Hiremath, Vaibhav
2011-08-24 13:25 ` Laurent Pinchart
2011-08-24 14:26 ` Hiremath, Vaibhav
2011-09-03 22:21 ` Mauro Carvalho Chehab
2011-09-04 9:01 ` Laurent Pinchart
2011-09-04 13:32 ` Mauro Carvalho Chehab
2011-09-05 12:49 ` Laurent Pinchart
2011-09-06 14:12 ` Hiremath, Vaibhav
2011-09-06 14:47 ` Laurent Pinchart
2011-09-07 2:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313761725-6614-1-git-send-email-deepthy.ravi@ti.com \
--to=deepthy.ravi@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).