public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: rjw@sisk.pl, menage@google.com, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, oleg@redhat.com
Subject: [PATCHSET] freezer: fix various bugs and simplify implementation
Date: Fri, 19 Aug 2011 16:16:06 +0200	[thread overview]
Message-ID: <1313763382-12341-1-git-send-email-tj@kernel.org> (raw)

Hello,

The freezer code has developed a number of convolutions and bugs.
It's now using five per-task flags - TIF_FREEZE, PF_FREEZING,
PF_NOFREEZE, PF_FROZEN, PF_FREEZER_SKIP and PF_FREEZER_NOSIG, and at
the same time has quite a few race conditions.  PF_NOFREEZE
modifications can race against PM freezer, cgroup_freezer can race
against PM freezer, and so on.

This patchset tries to simplify the freezer implementation and fix the
various bugs.  It makes the synchronization more straight forward and
replaces TIF_FREEZE with directly checking freeze conditions which are
in effect, which makes the whole thing much saner.

This patchset removes TIF_FREEZE and PF_FREEZING.  Also,
PF_FREEZER_SKIP users are planned to move away from the flag and will
be removed.  It contains the following 16 patches.

 0001-freezer-fix-current-state-restoration-race-in-refrig.patch
 0002-freezer-don-t-unnecessarily-set-PF_NOFREEZE-explicit.patch
 0003-freezer-unexport-refrigerator-and-update-try_to_free.patch
 0004-freezer-implement-and-use-kthread_freezable_should_s.patch
 0005-freezer-rename-thaw_process-to-__thaw_task-and-simpl.patch
 0006-freezer-make-exiting-tasks-properly-unfreezable.patch
 0007-freezer-don-t-distinguish-nosig-tasks-on-thaw.patch
 0008-freezer-use-dedicated-lock-instead-of-task_lock-memo.patch
 0009-freezer-make-freezing-indicate-freeze-condition-in-e.patch
 0010-freezer-fix-set_freezable-_with_signal-race.patch
 0011-freezer-kill-PF_FREEZING.patch
 0012-freezer-clean-up-freeze_processes-failure-path.patch
 0013-cgroup_freezer-prepare-for-removal-of-TIF_FREEZE.patch
 0014-freezer-make-freezing-test-freeze-conditions-in-effe.patch
 0015-freezer-remove-now-unused-TIF_FREEZE.patch
 0016-freezer-remove-should_send_signal-and-update-frozen.patch

This patchset is on top of the current linus#master (01b883358b "Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc") and
available in the following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git freezer

diffstat follows.

 Documentation/power/freezing-of-tasks.txt |   14 +-
 arch/alpha/include/asm/thread_info.h      |    2
 arch/arm/include/asm/thread_info.h        |    2
 arch/avr32/include/asm/thread_info.h      |    2
 arch/blackfin/include/asm/thread_info.h   |    2
 arch/cris/include/asm/thread_info.h       |    2
 arch/frv/include/asm/thread_info.h        |    2
 arch/h8300/include/asm/thread_info.h      |    2
 arch/ia64/include/asm/thread_info.h       |    2
 arch/m32r/include/asm/thread_info.h       |    2
 arch/m68k/include/asm/thread_info.h       |    1
 arch/microblaze/include/asm/thread_info.h |    2
 arch/mips/include/asm/thread_info.h       |    2
 arch/mn10300/include/asm/thread_info.h    |    2
 arch/parisc/include/asm/thread_info.h     |    2
 arch/powerpc/include/asm/thread_info.h    |    2
 arch/s390/include/asm/thread_info.h       |    2
 arch/sh/include/asm/thread_info.h         |    2
 arch/sparc/include/asm/thread_info_32.h   |    2
 arch/sparc/include/asm/thread_info_64.h   |    2
 arch/um/include/asm/thread_info.h         |    2
 arch/unicore32/include/asm/thread_info.h  |    2
 arch/x86/include/asm/thread_info.h        |    2
 arch/xtensa/include/asm/thread_info.h     |    2
 drivers/bluetooth/btmrvl_main.c           |    2
 drivers/mfd/twl4030-irq.c                 |    3
 drivers/mfd/twl6030-irq.c                 |    2
 drivers/net/irda/stir4200.c               |    2
 drivers/platform/x86/thinkpad_acpi.c      |   15 +-
 drivers/staging/rts_pstor/rtsx.c          |    2
 fs/btrfs/async-thread.c                   |    2
 fs/btrfs/disk-io.c                        |    8 -
 fs/ext4/super.c                           |    3
 fs/fs-writeback.c                         |    4
 fs/gfs2/log.c                             |    4
 fs/gfs2/quota.c                           |    4
 fs/jbd/journal.c                          |    2
 fs/jbd2/journal.c                         |    2
 fs/jfs/jfs_logmgr.c                       |    2
 fs/jfs/jfs_txnmgr.c                       |    4
 fs/nilfs2/segment.c                       |    2
 fs/xfs/linux-2.6/xfs_buf.c                |    2
 include/linux/freezer.h                   |   78 +++++--------
 include/linux/kthread.h                   |    1
 include/linux/sched.h                     |    3
 kernel/cgroup_freezer.c                   |   51 +++-----
 kernel/exit.c                             |    8 +
 kernel/fork.c                             |    1
 kernel/freezer.c                          |  179 +++++++++++++++++-------------
 kernel/kthread.c                          |   25 ++++
 kernel/power/hibernate.c                  |   15 --
 kernel/power/process.c                    |   65 +++-------
 kernel/power/user.c                       |    4
 mm/backing-dev.c                          |    8 -
 54 files changed, 247 insertions(+), 315 deletions(-)

Thanks.

--
tejun

             reply	other threads:[~2011-08-19 14:16 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 14:16 Tejun Heo [this message]
2011-08-19 14:16 ` [PATCH 01/16] freezer: fix current->state restoration race in refrigerator() Tejun Heo
2011-08-19 15:52   ` Oleg Nesterov
2011-08-19 16:11     ` Tejun Heo
2011-08-19 21:08   ` Rafael J. Wysocki
2011-08-20  8:13     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE explicitly Tejun Heo
2011-08-19 16:43   ` Gustavo Padovan
2011-08-22 15:05   ` Samuel Ortiz
2011-08-19 14:16 ` [PATCH 03/16] freezer: unexport refrigerator() and update try_to_freeze() slightly Tejun Heo
2011-08-19 14:16 ` [PATCH 04/16] freezer: implement and use kthread_freezable_should_stop() Tejun Heo
2011-08-19 20:07   ` Henrique de Moraes Holschuh
2011-08-21 19:14   ` Oleg Nesterov
2011-08-22  9:53     ` Tejun Heo
2011-08-23 15:42       ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 05/16] freezer: rename thaw_process() to __thaw_task() and simplify the implementation Tejun Heo
2011-08-19 15:37   ` Paul Menage
2011-08-24  2:28   ` Matt Helsley
2011-08-19 14:16 ` [PATCH 06/16] freezer: make exiting tasks properly unfreezable Tejun Heo
2011-08-23 15:52   ` Oleg Nesterov
2011-08-23 19:44     ` Tejun Heo
2011-08-24 14:14       ` Oleg Nesterov
2011-08-25 15:59         ` Tejun Heo
2011-08-25 16:56           ` Oleg Nesterov
2011-08-25 21:01             ` Rafael J. Wysocki
2011-08-25 21:54               ` Tejun Heo
2011-08-26 21:09                 ` Rafael J. Wysocki
2011-08-27 10:35                   ` Tejun Heo
2011-08-27 10:51                     ` Rafael J. Wysocki
2011-08-27 11:02                       ` Tejun Heo
2011-08-27 12:22                         ` Rafael J. Wysocki
2011-08-25 21:52             ` Tejun Heo
2011-08-24 22:34   ` Matt Helsley
2011-08-25 15:25     ` Oleg Nesterov
2011-08-25 16:11     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 07/16] freezer: don't distinguish nosig tasks on thaw Tejun Heo
2011-08-19 21:14   ` Rafael J. Wysocki
2011-08-20  8:10     ` Tejun Heo
2011-08-20  8:39       ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 08/16] freezer: use dedicated lock instead of task_lock() + memory barrier Tejun Heo
2011-08-28 17:51   ` Oleg Nesterov
2011-08-28 18:21     ` Oleg Nesterov
2011-08-29  7:20     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 09/16] freezer: make freezing indicate freeze condition in effect Tejun Heo
2011-08-28 17:56   ` Oleg Nesterov
2011-08-29  7:31     ` Tejun Heo
2011-08-29 17:44     ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 10/16] freezer: fix set_freezable[_with_signal]() race Tejun Heo
2011-08-28 18:01   ` Oleg Nesterov
2011-08-29  7:38     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 11/16] freezer: kill PF_FREEZING Tejun Heo
2011-08-19 14:16 ` [PATCH 12/16] freezer: clean up freeze_processes() failure path Tejun Heo
2011-08-28 18:09   ` Oleg Nesterov
2011-08-29  7:28     ` Tejun Heo
2011-08-29  7:40       ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 13/16] cgroup_freezer: prepare for removal of TIF_FREEZE Tejun Heo
2011-08-19 15:40   ` Paul Menage
2011-08-28 17:39   ` Oleg Nesterov
2011-08-29  6:30     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 14/16] freezer: make freezing() test freeze conditions in effect instead " Tejun Heo
2011-08-19 15:43   ` Paul Menage
2011-08-29 15:49   ` Oleg Nesterov
2011-08-29 15:56     ` Oleg Nesterov
2011-08-29 16:30       ` Oleg Nesterov
2011-08-29 16:17     ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 15/16] freezer: remove now unused TIF_FREEZE Tejun Heo
2011-08-19 14:16 ` [PATCH 16/16] freezer: remove should_send_signal() and update frozen() Tejun Heo
2011-08-19 14:23 ` [PATCHSET] freezer: fix various bugs and simplify implementation Tejun Heo
2011-08-19 15:34   ` Paul Menage
2011-08-19 16:25   ` Tejun Heo
2011-08-24  1:10     ` Matt Helsley
2011-08-19 21:00 ` Rafael J. Wysocki
2011-08-20  8:14   ` Tejun Heo
2011-09-05  8:52   ` [BUG] CPU hotplug, freezer: Freezing of tasks failed after 20.00 seconds Srivatsa S. Bhat
2011-09-05 14:15     ` Tejun Heo
2011-09-06  5:08       ` Tejun Heo
2011-09-06  6:01         ` Rafael J. Wysocki
2011-10-02 19:13           ` Srivatsa S. Bhat
2011-10-02 19:33             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313763382-12341-1-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=oleg@redhat.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox