public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: rjw@sisk.pl, menage@google.com, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, oleg@redhat.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 16/16] freezer: remove should_send_signal() and update frozen()
Date: Fri, 19 Aug 2011 16:16:22 +0200	[thread overview]
Message-ID: <1313763382-12341-17-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1313763382-12341-1-git-send-email-tj@kernel.org>

should_send_signal() is only used in freezer.c.  Exporting them only
increases chance of abuse.  Open code the two users and remove it.

Update frozen() to return bool.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 include/linux/freezer.h |    9 ++-------
 kernel/freezer.c        |    2 +-
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/include/linux/freezer.h b/include/linux/freezer.h
index 11b2bd9..122b5ce 100644
--- a/include/linux/freezer.h
+++ b/include/linux/freezer.h
@@ -15,7 +15,7 @@ extern bool pm_nosig_freezing;		/* PM nosig freezing in effect */
 /*
  * Check if a process has been frozen
  */
-static inline int frozen(struct task_struct *p)
+static inline bool frozen(struct task_struct *p)
 {
 	return p->flags & PF_FROZEN;
 }
@@ -32,11 +32,6 @@ static inline bool freezing(struct task_struct *p)
 	return freezing_slow_path(p);
 }
 
-static inline bool should_send_signal(struct task_struct *p)
-{
-	return !(p->flags & PF_FREEZER_NOSIG);
-}
-
 /* Takes and releases task alloc lock using task_lock() */
 extern void __thaw_task(struct task_struct *t);
 
@@ -156,7 +151,7 @@ static inline bool set_freezable_with_signal(void)
 	__retval;							\
 })
 #else /* !CONFIG_FREEZER */
-static inline int frozen(struct task_struct *p) { return 0; }
+static inline bool frozen(struct task_struct *p) { return false; }
 static inline bool freezing(struct task_struct *p) { return false; }
 
 static inline bool __refrigerator(bool check_kthr_stop) { return false; }
diff --git a/kernel/freezer.c b/kernel/freezer.c
index 995bddf..466ea6b 100644
--- a/kernel/freezer.c
+++ b/kernel/freezer.c
@@ -129,7 +129,7 @@ bool freeze_task(struct task_struct *p, bool sig_only)
 		return false;
 	}
 
-	if (should_send_signal(p)) {
+	if (!(p->flags & PF_FREEZER_NOSIG)) {
 		fake_signal_wake_up(p);
 		/*
 		 * fake_signal_wake_up() goes through p's scheduler
-- 
1.7.6


  parent reply	other threads:[~2011-08-19 14:17 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 14:16 [PATCHSET] freezer: fix various bugs and simplify implementation Tejun Heo
2011-08-19 14:16 ` [PATCH 01/16] freezer: fix current->state restoration race in refrigerator() Tejun Heo
2011-08-19 15:52   ` Oleg Nesterov
2011-08-19 16:11     ` Tejun Heo
2011-08-19 21:08   ` Rafael J. Wysocki
2011-08-20  8:13     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE explicitly Tejun Heo
2011-08-19 16:43   ` Gustavo Padovan
2011-08-22 15:05   ` Samuel Ortiz
2011-08-19 14:16 ` [PATCH 03/16] freezer: unexport refrigerator() and update try_to_freeze() slightly Tejun Heo
2011-08-19 14:16 ` [PATCH 04/16] freezer: implement and use kthread_freezable_should_stop() Tejun Heo
2011-08-19 20:07   ` Henrique de Moraes Holschuh
2011-08-21 19:14   ` Oleg Nesterov
2011-08-22  9:53     ` Tejun Heo
2011-08-23 15:42       ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 05/16] freezer: rename thaw_process() to __thaw_task() and simplify the implementation Tejun Heo
2011-08-19 15:37   ` Paul Menage
2011-08-24  2:28   ` Matt Helsley
2011-08-19 14:16 ` [PATCH 06/16] freezer: make exiting tasks properly unfreezable Tejun Heo
2011-08-23 15:52   ` Oleg Nesterov
2011-08-23 19:44     ` Tejun Heo
2011-08-24 14:14       ` Oleg Nesterov
2011-08-25 15:59         ` Tejun Heo
2011-08-25 16:56           ` Oleg Nesterov
2011-08-25 21:01             ` Rafael J. Wysocki
2011-08-25 21:54               ` Tejun Heo
2011-08-26 21:09                 ` Rafael J. Wysocki
2011-08-27 10:35                   ` Tejun Heo
2011-08-27 10:51                     ` Rafael J. Wysocki
2011-08-27 11:02                       ` Tejun Heo
2011-08-27 12:22                         ` Rafael J. Wysocki
2011-08-25 21:52             ` Tejun Heo
2011-08-24 22:34   ` Matt Helsley
2011-08-25 15:25     ` Oleg Nesterov
2011-08-25 16:11     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 07/16] freezer: don't distinguish nosig tasks on thaw Tejun Heo
2011-08-19 21:14   ` Rafael J. Wysocki
2011-08-20  8:10     ` Tejun Heo
2011-08-20  8:39       ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 08/16] freezer: use dedicated lock instead of task_lock() + memory barrier Tejun Heo
2011-08-28 17:51   ` Oleg Nesterov
2011-08-28 18:21     ` Oleg Nesterov
2011-08-29  7:20     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 09/16] freezer: make freezing indicate freeze condition in effect Tejun Heo
2011-08-28 17:56   ` Oleg Nesterov
2011-08-29  7:31     ` Tejun Heo
2011-08-29 17:44     ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 10/16] freezer: fix set_freezable[_with_signal]() race Tejun Heo
2011-08-28 18:01   ` Oleg Nesterov
2011-08-29  7:38     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 11/16] freezer: kill PF_FREEZING Tejun Heo
2011-08-19 14:16 ` [PATCH 12/16] freezer: clean up freeze_processes() failure path Tejun Heo
2011-08-28 18:09   ` Oleg Nesterov
2011-08-29  7:28     ` Tejun Heo
2011-08-29  7:40       ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 13/16] cgroup_freezer: prepare for removal of TIF_FREEZE Tejun Heo
2011-08-19 15:40   ` Paul Menage
2011-08-28 17:39   ` Oleg Nesterov
2011-08-29  6:30     ` Tejun Heo
2011-08-19 14:16 ` [PATCH 14/16] freezer: make freezing() test freeze conditions in effect instead " Tejun Heo
2011-08-19 15:43   ` Paul Menage
2011-08-29 15:49   ` Oleg Nesterov
2011-08-29 15:56     ` Oleg Nesterov
2011-08-29 16:30       ` Oleg Nesterov
2011-08-29 16:17     ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 15/16] freezer: remove now unused TIF_FREEZE Tejun Heo
2011-08-19 14:16 ` Tejun Heo [this message]
2011-08-19 14:23 ` [PATCHSET] freezer: fix various bugs and simplify implementation Tejun Heo
2011-08-19 15:34   ` Paul Menage
2011-08-19 16:25   ` Tejun Heo
2011-08-24  1:10     ` Matt Helsley
2011-08-19 21:00 ` Rafael J. Wysocki
2011-08-20  8:14   ` Tejun Heo
2011-09-05  8:52   ` [BUG] CPU hotplug, freezer: Freezing of tasks failed after 20.00 seconds Srivatsa S. Bhat
2011-09-05 14:15     ` Tejun Heo
2011-09-06  5:08       ` Tejun Heo
2011-09-06  6:01         ` Rafael J. Wysocki
2011-10-02 19:13           ` Srivatsa S. Bhat
2011-10-02 19:33             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313763382-12341-17-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=oleg@redhat.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox