From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756204Ab1HSQHJ (ORCPT ); Fri, 19 Aug 2011 12:07:09 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:42168 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144Ab1HSQHG (ORCPT ); Fri, 19 Aug 2011 12:07:06 -0400 Subject: Re: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Michal Marek Cc: adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 19 Aug 2011 19:08:51 +0300 In-Reply-To: <1313769360.6607.70.camel@sauron> References: <1313058586-24239-1-git-send-email-mmarek@suse.cz> <1313769360.6607.70.camel@sauron> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.2 (3.0.2-3.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1313770135.6607.71.camel@sauron> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-08-19 at 18:55 +0300, Artem Bityutskiy wrote: > On Thu, 2011-08-11 at 12:29 +0200, Michal Marek wrote: > > With > > $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config > > # CONFIG_UBIFS_FS_DEBUG is not set > > CONFIG_DYNAMIC_DEBUG=y > > > > Debug messages are kept in the object files due to the > > dynamic_pr_debug() macro, even if they are never going to be printed: > > $ make fs/ubifs/super.o > > $ strings fs/ubifs/super.o | grep 'compiled on' > > compiled on: Aug 11 2011 at 12:21:38 > > > > Use plain printk to fix this. > > > > Signed-off-by: Michal Marek > > Good catch, thanks! Pushed to ubifs-2.6.git, thanks! There is a similar issue in UBI - just fixed it. I'll send this to Linus soon, as this is a regression (blown-up binaries even though debugging is disabled). -- Best Regards, Artem Bityutskiy