* [PATCH] leds: add missing include of linux/module.h
@ 2011-08-21 14:20 Axel Lin
2011-08-22 18:05 ` Kristoffer Ericson
2011-08-22 22:12 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-08-21 14:20 UTC (permalink / raw)
To: linux-kernel
Cc: Jonathan McDowell, Kristoffer Ericson, Magnus Damm,
Richard Purdie, Andrew Morton
>From 157207e0166b05e33722c1c87bf3753ee22c94fa Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@gmail.com>
Date: Sun, 21 Aug 2011 22:14:44 +0800
Subject: [PATCH] leds: add missing include of linux/module.h
Add missing include of linux/module.h for drivers that
use interfaces from linux/module.h. This patch fixes build errors.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Jonathan McDowell <noodles@earth.li>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Cc: Magnus Damm <damm@opensource.se>
---
below is the build errors for leds-ams-delta.c.
I got similar buld errors for leds-hp6xx.c and leds-renesas-tpu.c.
CC drivers/leds/leds-ams-delta.o
drivers/leds/leds-ams-delta.c:116: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/leds/leds-ams-delta.c:133: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-ams-delta.c:133: warning: data definition has no type or storage class
drivers/leds/leds-ams-delta.c:133: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/leds/leds-ams-delta.c:133: warning: function declaration isn't a prototype
drivers/leds/leds-ams-delta.c:134: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-ams-delta.c:134: warning: data definition has no type or storage class
drivers/leds/leds-ams-delta.c:134: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/leds/leds-ams-delta.c:134: warning: function declaration isn't a prototype
drivers/leds/leds-ams-delta.c:135: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-ams-delta.c:135: warning: data definition has no type or storage class
drivers/leds/leds-ams-delta.c:135: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/leds/leds-ams-delta.c:135: warning: function declaration isn't a prototype
drivers/leds/leds-ams-delta.c:136: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-ams-delta.c:136: warning: data definition has no type or storage class
drivers/leds/leds-ams-delta.c:136: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
drivers/leds/leds-ams-delta.c:136: warning: function declaration isn't a prototype
make[2]: *** [drivers/leds/leds-ams-delta.o] Error 1
make[1]: *** [drivers/leds] Error 2
make: *** [drivers] Error 2
drivers/leds/leds-ams-delta.c | 1 +
drivers/leds/leds-hp6xx.c | 1 +
drivers/leds/leds-renesas-tpu.c | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/leds-ams-delta.c b/drivers/leds/leds-ams-delta.c
index b982603..8c00937 100644
--- a/drivers/leds/leds-ams-delta.c
+++ b/drivers/leds/leds-ams-delta.c
@@ -8,6 +8,7 @@
* published by the Free Software Foundation.
*/
+#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/platform_device.h>
diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c
index e4ce1fd..bcfbd3a 100644
--- a/drivers/leds/leds-hp6xx.c
+++ b/drivers/leds/leds-hp6xx.c
@@ -10,6 +10,7 @@
* published by the Free Software Foundation.
*/
+#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/platform_device.h>
diff --git a/drivers/leds/leds-renesas-tpu.c b/drivers/leds/leds-renesas-tpu.c
index 5bfb40e1..d9a7d72 100644
--- a/drivers/leds/leds-renesas-tpu.c
+++ b/drivers/leds/leds-renesas-tpu.c
@@ -17,6 +17,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
+#include <linux/module.h>
#include <linux/init.h>
#include <linux/platform_device.h>
#include <linux/spinlock.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add missing include of linux/module.h
2011-08-21 14:20 [PATCH] leds: add missing include of linux/module.h Axel Lin
@ 2011-08-22 18:05 ` Kristoffer Ericson
2011-08-22 22:12 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Kristoffer Ericson @ 2011-08-22 18:05 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jonathan McDowell, Magnus Damm, Richard Purdie,
Andrew Morton
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
On Sun, Aug 21, 2011 at 10:20:07PM +0800, Axel Lin wrote:
> >From 157207e0166b05e33722c1c87bf3753ee22c94fa Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Sun, 21 Aug 2011 22:14:44 +0800
> Subject: [PATCH] leds: add missing include of linux/module.h
>
> Add missing include of linux/module.h for drivers that
> use interfaces from linux/module.h. This patch fixes build errors.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Jonathan McDowell <noodles@earth.li>
> Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> Cc: Magnus Damm <damm@opensource.se>
> ---
> below is the build errors for leds-ams-delta.c.
> I got similar buld errors for leds-hp6xx.c and leds-renesas-tpu.c.
>
> CC drivers/leds/leds-ams-delta.o
> drivers/leds/leds-ams-delta.c:116: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/leds/leds-ams-delta.c:133: error: expected declaration specifiers or '...' before string constant
> drivers/leds/leds-ams-delta.c:133: warning: data definition has no type or storage class
> drivers/leds/leds-ams-delta.c:133: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/leds/leds-ams-delta.c:133: warning: function declaration isn't a prototype
> drivers/leds/leds-ams-delta.c:134: error: expected declaration specifiers or '...' before string constant
> drivers/leds/leds-ams-delta.c:134: warning: data definition has no type or storage class
> drivers/leds/leds-ams-delta.c:134: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/leds/leds-ams-delta.c:134: warning: function declaration isn't a prototype
> drivers/leds/leds-ams-delta.c:135: error: expected declaration specifiers or '...' before string constant
> drivers/leds/leds-ams-delta.c:135: warning: data definition has no type or storage class
> drivers/leds/leds-ams-delta.c:135: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/leds/leds-ams-delta.c:135: warning: function declaration isn't a prototype
> drivers/leds/leds-ams-delta.c:136: error: expected declaration specifiers or '...' before string constant
> drivers/leds/leds-ams-delta.c:136: warning: data definition has no type or storage class
> drivers/leds/leds-ams-delta.c:136: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
> drivers/leds/leds-ams-delta.c:136: warning: function declaration isn't a prototype
> make[2]: *** [drivers/leds/leds-ams-delta.o] Error 1
> make[1]: *** [drivers/leds] Error 2
> make: *** [drivers] Error 2
>
> drivers/leds/leds-ams-delta.c | 1 +
> drivers/leds/leds-hp6xx.c | 1 +
> drivers/leds/leds-renesas-tpu.c | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/leds/leds-ams-delta.c b/drivers/leds/leds-ams-delta.c
> index b982603..8c00937 100644
> --- a/drivers/leds/leds-ams-delta.c
> +++ b/drivers/leds/leds-ams-delta.c
> @@ -8,6 +8,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c
> index e4ce1fd..bcfbd3a 100644
> --- a/drivers/leds/leds-hp6xx.c
> +++ b/drivers/leds/leds-hp6xx.c
> @@ -10,6 +10,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/leds/leds-renesas-tpu.c b/drivers/leds/leds-renesas-tpu.c
> index 5bfb40e1..d9a7d72 100644
> --- a/drivers/leds/leds-renesas-tpu.c
> +++ b/drivers/leds/leds-renesas-tpu.c
> @@ -17,6 +17,7 @@
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> +#include <linux/module.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> #include <linux/spinlock.h>
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add missing include of linux/module.h
2011-08-21 14:20 [PATCH] leds: add missing include of linux/module.h Axel Lin
2011-08-22 18:05 ` Kristoffer Ericson
@ 2011-08-22 22:12 ` Andrew Morton
2011-08-23 1:00 ` Stephen Rothwell
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2011-08-22 22:12 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jonathan McDowell, Kristoffer Ericson, Magnus Damm,
Richard Purdie
On Sun, 21 Aug 2011 22:20:07 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Add missing include of linux/module.h for drivers that
> use interfaces from linux/module.h. This patch fixes build errors.
>
> ...
>
> drivers/leds/leds-ams-delta.c | 1 +
> drivers/leds/leds-hp6xx.c | 1 +
> drivers/leds/leds-renesas-tpu.c | 1 +
I'm seeing no leds-renesas-tpu.c in my tree, so whatever tree holds
that file will remain unfixed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add missing include of linux/module.h
2011-08-22 22:12 ` Andrew Morton
@ 2011-08-23 1:00 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2011-08-23 1:00 UTC (permalink / raw)
To: Andrew Morton
Cc: Axel Lin, linux-kernel, Jonathan McDowell, Kristoffer Ericson,
Magnus Damm, Richard Purdie
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Andrew,
On Mon, 22 Aug 2011 15:12:00 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun, 21 Aug 2011 22:20:07 +0800
> Axel Lin <axel.lin@gmail.com> wrote:
>
> > Add missing include of linux/module.h for drivers that
> > use interfaces from linux/module.h. This patch fixes build errors.
> >
> > ...
> >
> > drivers/leds/leds-ams-delta.c | 1 +
> > drivers/leds/leds-hp6xx.c | 1 +
> > drivers/leds/leds-renesas-tpu.c | 1 +
>
> I'm seeing no leds-renesas-tpu.c in my tree, so whatever tree holds
> that file will remain unfixed.
The only place that files exists in linux-next is in the akpm tree in
leds-renesas-tpu-led-driver-v2.patch,
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-23 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-21 14:20 [PATCH] leds: add missing include of linux/module.h Axel Lin
2011-08-22 18:05 ` Kristoffer Ericson
2011-08-22 22:12 ` Andrew Morton
2011-08-23 1:00 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox