Re: [PATCH v2] drivers:uio:change the goto label to consistent with others

Hans J. Koch
2011-08-22T11:30:28Z

On Sat, Aug 20, 2011 at 12:12:08PM +0800, Wanlong Gao wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>
> sorry for v1's typo mistake.
> Thanks
>
> Remove one *goto* label in uio.c.

Nice, that makes it a bit cleaner.

Thanks,
Hans

>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>

> ---
> drivers/uio/uio.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index d2efe82..c89f12a 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -750,14 +750,13 @@ static int uio_major_init(void)
>
> uio_major = MAJOR(uio_dev);
> uio_cdev = cdev;
> - result = 0;
> -out:
> - return result;
> + return 0;
> out_put:
> kobject_put(&cdev->kobj);
> out_unregister:
> unregister_chrdev_region(uio_dev, UIO_MAX_DEVICES);
> - goto out;
> +out:
> + return result;
> }
>
> static void uio_major_cleanup(void)
> --
> 1.7.4.1
>
>