From: Joe Perches <joe@perches.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH] nohz: remove "Switched to NOHz mode" debugging messages
Date: Tue, 23 Aug 2011 12:12:57 -0700 [thread overview]
Message-ID: <1314126777.1659.2.camel@Joe-Laptop> (raw)
In-Reply-To: <20110823112046.GB2540@osiris.boeblingen.de.ibm.com>
On Tue, 2011-08-23 at 13:20 +0200, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> When performing cpu hotplug tests the kernel printk log buffer gets flooded
> with pointless "Switched to NOHz mode..." messages. Especially when afterwards
> analyzing a dump this might have removed more interesting stuff out of the
> buffer.
> Assuming that switching to NOHz mode simply works just remove the printk.
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
[]
> -
> - printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());
Though I don't know if these are actually particularly
useful messages, perhaps pr_info_ratelimited() might
be appropriate instead.
> @@ -793,10 +791,8 @@ void tick_setup_sched_timer(void)
> - printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());
and here.
next prev parent reply other threads:[~2011-08-23 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 11:20 [PATCH] nohz: remove "Switched to NOHz mode" debugging messages Heiko Carstens
2011-08-23 19:12 ` Joe Perches [this message]
2011-08-23 19:15 ` Stephen Boyd
2011-08-24 5:52 ` Heiko Carstens
2011-08-23 22:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314126777.1659.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox