From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590Ab1HXM4W (ORCPT ); Wed, 24 Aug 2011 08:56:22 -0400 Received: from mga14.intel.com ([143.182.124.37]:63286 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795Ab1HXM4V convert rfc822-to-8bit (ORCPT ); Wed, 24 Aug 2011 08:56:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,275,1312182000"; d="scan'208";a="41891853" Subject: RE: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and From: Andy Shevchenko To: "Hiremath, Vaibhav" Cc: Laurent Pinchart , "Ravi, Deepthy" , "mchehab@infradead.org" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" In-Reply-To: <19F8576C6E063C45BE387C64729E739404EC007BE3@dbde02.ent.ti.com> References: <1313761725-6614-1-git-send-email-deepthy.ravi@ti.com> <201108241217.11430.laurent.pinchart@ideasonboard.com> <201108241329.48147.laurent.pinchart@ideasonboard.com> <19F8576C6E063C45BE387C64729E739404EC007BE3@dbde02.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Organization: Intel Finland Oy Date: Wed, 24 Aug 2011 15:55:38 +0300 Message-ID: <1314190538.9124.29.camel@smile> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > >> Fix the build break caused when CONFIG_MEDIA_CONTROLLER > > > >> option is disabled and if any sensor driver has to be used > > > >> between MC and non MC framework compatible devices. > > > >> > > > >> For example,if tvp514x video decoder driver migrated to > > > >> MC framework is being built without CONFIG_MEDIA_CONTROLLER > > > >> option enabled, the following error messages will result. > > > >> drivers/built-in.o: In function `tvp514x_remove': > > > >> drivers/media/video/tvp514x.c:1285: undefined reference to > > > >> `media_entity_cleanup' > > > >> drivers/built-in.o: In function `tvp514x_probe': > > > >> drivers/media/video/tvp514x.c:1237: undefined reference to > > > >> `media_entity_init' > > > > > > > > If the tvp514x is migrated to the MC framework, its Kconfig option > > should > > > > depend on MEDIA_CONTROLLER. > > > > > > The same TVP514x driver is being used for both MC and non MC compatible > > > devices, for example OMAP3 and AM35x. So if it is made dependent on > > MEDIA > > > CONTROLLER, we cannot enable the driver for MC independent devices. > > > > Then you should use conditional compilation in the tvp514x driver itself. > > Or > [Hiremath, Vaibhav] No. I am not in favor of conditional compilation in driver code. > > > better, port the AM35x driver to the MC API. > > > [Hiremath, Vaibhav] > Why should we use MC if I have very simple device (like AM35x) which only supports single path? I can very well use simple V4L2 sub-dev based approach (master - slave), isn't it? Why should you break the API in unappropriated way? The patch is NACK, obviously. -- Andy Shevchenko Intel Finland Oy