From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754928AbcBHQkm (ORCPT ); Mon, 8 Feb 2016 11:40:42 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:64114 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbcBHQkk (ORCPT ); Mon, 8 Feb 2016 11:40:40 -0500 From: Arnd Bergmann To: Joao Pinto Cc: helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, CARLOS.PALMINHA@synopsys.com Subject: Re: [PATCH] link up validation moved to pcie-designware Date: Mon, 08 Feb 2016 17:40:30 +0100 Message-ID: <13142496.gh5Gdib4M6@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DD76Z0srLFjtFU9m5i2JKa6toDks4C17j87XVDSvuI6fF9kXVuN U/e1zDkLAeEHP9GkSAPHJq6ElhVWvuk9ZT6JhUSPnv/yIj5qwCEcuw6hEuODMpjVa1vjO3U xSMtV1kvHxBlS3h35KVpdcTWcZM8ZSUP+gvOrKcfEIdI2juqoxfkNrnzPWS4I730xhXpOiD +rkHL+0dZXae0XBOqmdFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:babTbIVe9Uw=:dR397rz9ABsTdIVRfff7sK o5mphhWlJA1oFwYal4+slMdkkoid3QVpRrGiZxz6+TbCN3Ky4M53uLbeuMlHPDFj+lyEFkIlO C7JsB+SnD1givN52IDVuEda1zPLEDOrAEoN3yvQmcFcUryLGE9w/HO+aG/N4I7ShwSFK8hv1W mxlgB+GIfK4kMVtYJyv44sBFn+1qnqX6u8thzKGaElyaJ1ch0FmFszFWhou0yJ/yeQ2bZSjwb SEJPyDHka1Z5R+6hBT0hf0vGZGE0bgr4ZX/azMWU+3B47iafNvYZKV2c36apj9Bpg0NyaLOjq ApXBewFOoPJfNc8PxknvSYmXZhC/pwCJPAdC0x3ljzJkUdxVl/HJe8lqt7nwvgliVelaJf/1h eWh3jfhbTVGwTdB7C2BRT/YLbN9VDh5Q68w3Hu674MpRnbj3q4sy62AO5T9qATqmqjiP4Dq2p RY2fMgGNGht2ARYKRlks8vTearP4GwvLQSOmnDpNomDULrNheUmSRhfhHeIzGfm81kOiIXW6Z bd2agqAhHTmHyoDWDSc+6ad381mqmR5pdBlztdG89qGVUU9RWuR9eu191nh8E07UPZse7S0GU +V7o0iPMisKBMwEvN4PgTOo3SuhydkYKKgzBpm/fD1cFvxqRRueqHV2up9XW0uvt9hu7yTsTt /8PTKrPZGL8JbwIGHvlpR17iGv4Iz1AtTCG2/+GGE+RNEmflW+kjBqZPSZiYe3G+N2+b9FAZs mHMcJ8ayZ+DfsqK4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 12:43:58 Joao Pinto wrote: > This patch goal is to centralize in pcie-designware the link up > validation. A new function was added to pci-designware that is > responsible for doing such a task. This was implemented in a form that > permits flexibility for all SoCs. > > Signed-off-by: Joao Pinto I believe the different timeouts in each driver are just coincidence and partly based on who reviewed which driver. I'm pretty sure it doesn't really matter at all, and we can just use the same loop for every one. I was also hoping that a little more than just the loop could be unified between the various establish_link() functions. I have a feeling that each one just implements a subset of what is actually required, so they are buggy in different ways because nobody has the datasheet. Arnd