From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Vijay Badawadagi <bvijay@ti.com>,
Pavan Savoy <pavan_savoy@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 09/13] drivers:misc: ti-st: fail-safe on wrong pkt type
Date: Fri, 26 Aug 2011 13:33:50 -0700 [thread overview]
Message-ID: <1314390834-3411-9-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <1314390834-3411-1-git-send-email-gregkh@suse.de>
From: Vijay Badawadagi <bvijay@ti.com>
Texas Instrument's shared transport driver interpret incoming data from the
UART based on the various protocol drivers registered to the driver such as
btwilink driver or FM or GPS driver which provide logical channel IDs.
In case of bad-behavior from chip such as HCI Event response for a GPS command
or a HCI Event (h/w error event) for a FM response & In case of bad-behavior
from UART driver such as dropping data bytes a fail-safe is required to avoid
kernel panic.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Vijay Badawadagi <bvijay@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/misc/ti-st/st_core.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index c8e335d..1f973ce 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -338,6 +338,12 @@ void st_int_recv(void *disc_data,
/* Unknow packet? */
default:
type = *ptr;
+ if (st_gdata->list[type] == NULL) {
+ pr_err("chip/interface misbehavior dropping"
+ " frame starting with 0x%02x", type);
+ goto done;
+
+ }
st_gdata->rx_skb = alloc_skb(
st_gdata->list[type]->max_frame_size,
GFP_ATOMIC);
@@ -354,6 +360,7 @@ void st_int_recv(void *disc_data,
ptr++;
count--;
}
+done:
spin_unlock_irqrestore(&st_gdata->lock, flags);
pr_debug("done %s", __func__);
return;
--
1.7.6.1
next prev parent reply other threads:[~2011-08-26 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 19:11 [GIT PATCH] driver core fixes for 3.1 Greg KH
2011-08-26 20:33 ` [PATCH 01/13] firmware: fix google/gsmi.c build warning Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 02/13] driver core: fix kernel-doc warning in platform.c Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 03/13] drivers/base/devtmpfs.c: correct annotation of `setup_done' Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 04/13] pti: add missing CONFIG_PCI dependency Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 05/13] base/devres.c: quiet sparse noise about context imbalance Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 06/13] drivers:misc: ti-st: avoid a misleading dbg msg Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 07/13] drivers:misc:ti-st: platform hooks for chip states Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 08/13] drivers:misc: ti-st: reinit completion on ver read Greg Kroah-Hartman
2011-08-26 20:33 ` Greg Kroah-Hartman [this message]
2011-08-26 20:33 ` [PATCH 10/13] drivers:misc: ti-st: reinit completion before send Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 11/13] drivers:misc: ti-st: wait for completion at fail Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 12/13] drivers:misc: ti-st: free skb on firmware download Greg Kroah-Hartman
2011-08-26 20:33 ` [PATCH 13/13] drivers:misc: ti-st: fix unexpected UART close Greg Kroah-Hartman
2011-08-26 20:54 ` [PATCH 01/13] firmware: fix google/gsmi.c build warning Mike Waychison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314390834-3411-9-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=bvijay@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox