From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, eric.dumazet@gmail.com,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 4/4] posix-timers: turn it_signal into it_valid flag
Date: Mon, 29 Aug 2011 16:39:17 -0700 [thread overview]
Message-ID: <1314661157-22173-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1314661157-22173-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Now that the timer IDR is per process we don't need to save
the signal_struct in the timer anymore. Still need this
as a flag for RCU, so turn it into a it_valid flag.
Suggested by Eric Dumazet
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
include/linux/posix-timers.h | 2 +-
kernel/posix-timers.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/posix-timers.h b/include/linux/posix-timers.h
index 959c141..02c1f04 100644
--- a/include/linux/posix-timers.h
+++ b/include/linux/posix-timers.h
@@ -63,7 +63,7 @@ struct k_itimer {
int it_requeue_pending; /* waiting to requeue this timer */
#define REQUEUE_PENDING 1
int it_sigev_notify; /* notify word of sigevent struct */
- struct signal_struct *it_signal;
+ int it_valid;
union {
struct pid *it_pid; /* pid of process to send signal to */
struct task_struct *it_process; /* for clock_nanosleep */
diff --git a/kernel/posix-timers.c b/kernel/posix-timers.c
index 320659d..5b27641 100644
--- a/kernel/posix-timers.c
+++ b/kernel/posix-timers.c
@@ -618,7 +618,7 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
goto out;
spin_lock_irq(¤t->sighand->siglock);
- new_timer->it_signal = current->signal;
+ new_timer->it_valid = 1;
list_add(&new_timer->list, ¤t->signal->posix_timers);
spin_unlock_irq(¤t->sighand->siglock);
@@ -650,7 +650,7 @@ static struct k_itimer *__lock_timer(timer_t timer_id, unsigned long *flags)
timr = idr_find(&s->posix_timers_id, (int)timer_id);
if (timr) {
spin_lock_irqsave(&timr->it_lock, *flags);
- if (timr->it_signal == current->signal) {
+ if (timr->it_valid) {
rcu_read_unlock();
return timr;
}
@@ -908,7 +908,7 @@ retry_delete:
* This keeps any tasks waiting on the spin lock from thinking
* they got something (see the lock code above).
*/
- timer->it_signal = NULL;
+ timer->it_valid = 0;
unlock_timer(timer, flags);
release_posix_timer(timer, IT_ID_SET);
@@ -934,7 +934,7 @@ retry_delete:
* This keeps any tasks waiting on the spin lock from thinking
* they got something (see the lock code above).
*/
- timer->it_signal = NULL;
+ timer->it_valid = 0;
unlock_timer(timer, flags);
release_posix_timer(timer, IT_ID_SET);
--
1.7.4.4
next prev parent reply other threads:[~2011-08-29 23:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 23:39 [PATCH 1/4] posix-timers: move global timer id management to signal_struct v2 Andi Kleen
2011-08-29 23:39 ` [PATCH 2/4] posix-timers: limit the number of posix timers per process Andi Kleen
2011-08-30 21:44 ` Andrew Morton
2011-08-30 22:06 ` Andi Kleen
2011-08-30 22:22 ` Andrew Morton
2011-08-30 22:47 ` Andi Kleen
2011-08-30 23:02 ` Andrew Morton
2011-08-31 6:45 ` Jiri Slaby
2011-09-02 9:30 ` Thomas Gleixner
2011-08-29 23:39 ` [PATCH 3/4] posix-timers: Don't disable interrupts in idr_lock Andi Kleen
2011-08-29 23:39 ` Andi Kleen [this message]
2011-09-02 10:06 ` [PATCH 4/4] posix-timers: turn it_signal into it_valid flag Thomas Gleixner
2011-09-02 11:49 ` Eric Dumazet
2011-09-02 14:19 ` Thomas Gleixner
2011-09-04 16:56 ` Oleg Nesterov
2011-09-04 19:07 ` Andi Kleen
2011-09-04 20:29 ` Oleg Nesterov
2011-09-06 3:14 ` Andi Kleen
2011-09-06 14:51 ` Oleg Nesterov
2011-09-06 15:39 ` Eric Dumazet
2011-09-06 16:27 ` Oleg Nesterov
2011-09-06 18:47 ` Thomas Gleixner
2011-09-06 18:49 ` Oleg Nesterov
2011-09-06 19:16 ` Thomas Gleixner
2011-09-06 19:26 ` Oleg Nesterov
2011-09-06 19:45 ` Thomas Gleixner
2011-09-06 22:08 ` Oleg Nesterov
2011-09-06 22:34 ` Thomas Gleixner
2011-09-21 16:46 ` Thomas Gleixner
2011-09-21 17:56 ` Thomas Gleixner
2011-09-22 11:19 ` Thomas Gleixner
2011-09-06 19:30 ` Eric Dumazet
2011-09-06 20:10 ` Thomas Gleixner
2011-09-06 20:27 ` Eric Dumazet
2011-09-06 19:04 ` Eric Dumazet
2011-08-31 8:53 ` [PATCH 1/4] posix-timers: move global timer id management to signal_struct v2 Eric Dumazet
2011-08-31 16:57 ` Andi Kleen
2011-09-02 9:19 ` Thomas Gleixner
2011-09-02 10:05 ` Eric Dumazet
2011-09-19 21:46 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314661157-22173-4-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).