public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Leonid V. Fedorenchik" <leonidsbox@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Ruslan Pisarev <ruslan@rpisarev.org.ua>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	Ilya Gorskin <Revent82@gmail.com>, Joe Perches <joe@perches.com>,
	Palash Bandyopadhyay <palash.bandyopadhyay@conexant.com>,
	Hans Verkuil <hverkuil@xs4all.nl>, Arnd Bergmann <arnd@arndb.de>,
	Youquan Song <youquan.song@intel.com>,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	"Leonid V. Fedorenchik" <leonidsbox@gmail.com>
Subject: [PATCH v3 12/18] Staging: cx25821: Replace :? by if-else in cx25821-video-upstream-ch2.c
Date: Tue, 30 Aug 2011 12:17:07 +0800	[thread overview]
Message-ID: <1314677833-4689-13-git-send-email-leonidsbox@gmail.com> (raw)
In-Reply-To: <1314677833-4689-1-git-send-email-leonidsbox@gmail.com>

Replace :? operator by if-else equivalent where it improves readability.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
---
 .../staging/cx25821/cx25821-video-upstream-ch2.c   |   23 ++++++++++---------
 1 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c b/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
index 655357d..a642416 100644
--- a/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
+++ b/drivers/staging/cx25821/cx25821-video-upstream-ch2.c
@@ -145,15 +145,16 @@ int cx25821_risc_buffer_upstream_ch2(struct cx25821_dev *dev,
 	if (dev->_isNTSC_ch2) {
 		odd_num_lines = singlefield_lines + 1;
 		risc_program_size = FRAME1_VID_PROG_SIZE;
-		frame_size =
-		    (bpl ==
-		     Y411_LINE_SZ) ? FRAME_SIZE_NTSC_Y411 :
-		    FRAME_SIZE_NTSC_Y422;
+		if (bpl == Y411_LINE_SZ)
+			frame_size = FRAME_SIZE_NTSC_Y411;
+		else
+			frame_size = FRAME_SIZE_NTSC_Y422;
 	} else {
 		risc_program_size = PAL_VID_PROG_SIZE;
-		frame_size =
-		    (bpl ==
-		     Y411_LINE_SZ) ? FRAME_SIZE_PAL_Y411 : FRAME_SIZE_PAL_Y422;
+		if (bpl == Y411_LINE_SZ)
+			frame_size = FRAME_SIZE_PAL_Y411;
+		else
+			frame_size = FRAME_SIZE_PAL_Y422;
 	}
 
 	/* Virtual address of Risc buffer program */
@@ -565,10 +566,10 @@ int cx25821_video_upstream_irq_ch2(struct cx25821_dev *dev, int chan_num,
 			}
 
 			if (dev->_dma_virt_start_addr_ch2 != NULL) {
-				line_size_in_bytes =
-				    (dev->_pixel_format_ch2 ==
-				     PIXEL_FRMT_411) ? Y411_LINE_SZ :
-				    Y422_LINE_SZ;
+				if (dev->_pixel_format_ch2 == PIXEL_FRMT_411)
+					line_size_in_bytes = Y411_LINE_SZ;
+				else
+					line_size_in_bytes = Y422_LINE_SZ;
 				risc_phys_jump_addr =
 				    dev->_dma_phys_start_addr_ch2 +
 				    odd_risc_prog_size;
-- 
1.7.0.4


  parent reply	other threads:[~2011-08-30  4:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30  4:16 [PATCH v3 00/18] Staging: cx25821: Fix style issues Leonid V. Fedorenchik
2011-08-30  4:16 ` [PATCH v3 01/18] Staging: cx25821: Get rid of typedef in cx25821.h Leonid V. Fedorenchik
2011-08-30  4:16 ` [PATCH v3 02/18] Staging: cx25821: Delete file cx25821-gpio.h Leonid V. Fedorenchik
2011-08-30  4:16 ` [PATCH v3 03/18] Staging: cx25821: Move EXPORT_SYMBOL() to the right place Leonid V. Fedorenchik
2011-08-30  4:16 ` [PATCH v3 04/18] Staging: cx25821: Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 05/18] Staging: cx25821: Fix wrong brace placement in cx25821-cards.c Leonid V. Fedorenchik
2011-08-30 14:05   ` Dan Carpenter
2011-08-31  6:26     ` Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 06/18] Staging: cx25821: Fix wrong brace placement in cx25821-core.c Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 07/18] Staging: cx25821: Fix wrong brace placement in cx25821-i2c.c Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 08/18] Staging: cx25821: Fix too long lines in cx25821-audio.h Leonid V. Fedorenchik
2011-08-30 14:08   ` Dan Carpenter
2011-08-31  6:27     ` Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 09/18] Staging: cx25821: Fix obscure line endings in cx25821-audio-upstream.c Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 10/18] Staging: cx25821: Fix long lines " Leonid V. Fedorenchik
2011-08-30 14:12   ` Dan Carpenter
2011-08-31  6:56     ` Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 11/18] Staging: cx25821: Fix long lines in cx25821-audio-upstream.h Leonid V. Fedorenchik
2011-08-30  4:17 ` Leonid V. Fedorenchik [this message]
2011-08-30  4:17 ` [PATCH v3 13/18] Staging: cx25821: Fix labels' placement in cx25821-video-upstream-ch2.c Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 14/18] Staging: cx25821: Fix wrong line endings " Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 15/18] Staging: cx25821: Fix long lines " Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 16/18] Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.h Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 17/18] Staging: cx25821: Fix long lines in cx25821-video-upstream.c Leonid V. Fedorenchik
2011-08-30  4:17 ` [PATCH v3 18/18] Staging: cx25821: Fix long lines in cx25821-video-upstream.h Leonid V. Fedorenchik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314677833-4689-13-git-send-email-leonidsbox@gmail.com \
    --to=leonidsbox@gmail.com \
    --cc=Revent82@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=hverkuil@xs4all.nl \
    --cc=imirkin@alum.mit.edu \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=palash.bandyopadhyay@conexant.com \
    --cc=ruslan@rpisarev.org.ua \
    --cc=youquan.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox