* [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
@ 2011-08-30 7:08 Axel Lin
2011-09-02 8:21 ` Wolfram Sang
2011-09-05 13:21 ` Vinod Koul
0 siblings, 2 replies; 9+ messages in thread
From: Axel Lin @ 2011-08-30 7:08 UTC (permalink / raw)
To: linux-kernel; +Cc: Sascha Hauer, Vinod Koul, Dan Williams
Add missing include of linux/module.h to fix build error.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/dma/imx-dma.c | 1 +
drivers/dma/imx-sdma.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index d99f71c..d746899 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -14,6 +14,7 @@
* http://www.gnu.org/copyleft/gpl.html
*/
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/types.h>
#include <linux/mm.h>
#include <linux/interrupt.h>
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index b5cc27d..eab1fe7 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -18,6 +18,7 @@
*/
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/types.h>
#include <linux/mm.h>
#include <linux/interrupt.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-08-30 7:08 [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h Axel Lin
@ 2011-09-02 8:21 ` Wolfram Sang
2011-09-05 13:21 ` Vinod Koul
1 sibling, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2011-09-02 8:21 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Sascha Hauer, Vinod Koul, Dan Williams
[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]
On Tue, Aug 30, 2011 at 03:08:24PM +0800, Axel Lin wrote:
> Add missing include of linux/module.h to fix build error.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Sascha is on holiday, so please accept my:
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/dma/imx-dma.c | 1 +
> drivers/dma/imx-sdma.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index d99f71c..d746899 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -14,6 +14,7 @@
> * http://www.gnu.org/copyleft/gpl.html
> */
> #include <linux/init.h>
> +#include <linux/module.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> #include <linux/interrupt.h>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index b5cc27d..eab1fe7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -18,6 +18,7 @@
> */
>
> #include <linux/init.h>
> +#include <linux/module.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> #include <linux/interrupt.h>
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-08-30 7:08 [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h Axel Lin
2011-09-02 8:21 ` Wolfram Sang
@ 2011-09-05 13:21 ` Vinod Koul
2011-09-05 13:32 ` Axel Lin
1 sibling, 1 reply; 9+ messages in thread
From: Vinod Koul @ 2011-09-05 13:21 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Sascha Hauer, Dan Williams
On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
> Add missing include of linux/module.h to fix build error.
I don't see this build error in my tree (based on rc4), In which config
is this seen?
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/dma/imx-dma.c | 1 +
> drivers/dma/imx-sdma.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index d99f71c..d746899 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -14,6 +14,7 @@
> * http://www.gnu.org/copyleft/gpl.html
> */
> #include <linux/init.h>
> +#include <linux/module.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> #include <linux/interrupt.h>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index b5cc27d..eab1fe7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -18,6 +18,7 @@
> */
>
> #include <linux/init.h>
> +#include <linux/module.h>
> #include <linux/types.h>
> #include <linux/mm.h>
> #include <linux/interrupt.h>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-09-05 13:21 ` Vinod Koul
@ 2011-09-05 13:32 ` Axel Lin
2011-09-05 14:36 ` Vinod Koul
0 siblings, 1 reply; 9+ messages in thread
From: Axel Lin @ 2011-09-05 13:32 UTC (permalink / raw)
To: Vinod Koul; +Cc: linux-kernel, Sascha Hauer, Dan Williams
2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
> On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
>> Add missing include of linux/module.h to fix build error.
> I don't see this build error in my tree (based on rc4), In which config
> is this seen?
The patch is against linux-next tree.
I got the build error by "make imx_v4_v5_defconfig" on linux-next tree
( next-20110831 )
Regards,
Axel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-09-05 13:32 ` Axel Lin
@ 2011-09-05 14:36 ` Vinod Koul
2011-09-20 13:22 ` Axel Lin
0 siblings, 1 reply; 9+ messages in thread
From: Vinod Koul @ 2011-09-05 14:36 UTC (permalink / raw)
To: axel.lin; +Cc: linux-kernel, Sascha Hauer, Dan Williams
On Mon, 2011-09-05 at 21:32 +0800, Axel Lin wrote:
> 2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
> > On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
> >> Add missing include of linux/module.h to fix build error.
> > I don't see this build error in my tree (based on rc4), In which config
> > is this seen?
> The patch is against linux-next tree.
> I got the build error by "make imx_v4_v5_defconfig" on linux-next tree
> ( next-20110831 )
Sorry I am not able to find it, can you please point me to archives..
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-09-05 14:36 ` Vinod Koul
@ 2011-09-20 13:22 ` Axel Lin
2011-09-20 16:42 ` Vinod Koul
0 siblings, 1 reply; 9+ messages in thread
From: Axel Lin @ 2011-09-20 13:22 UTC (permalink / raw)
To: Vinod Koul; +Cc: linux-kernel, Sascha Hauer, Dan Williams
2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
> On Mon, 2011-09-05 at 21:32 +0800, Axel Lin wrote:
>> 2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
>> > On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
>> >> Add missing include of linux/module.h to fix build error.
>> > I don't see this build error in my tree (based on rc4), In which config
>> > is this seen?
>> The patch is against linux-next tree.
>> I got the build error by "make imx_v4_v5_defconfig" on linux-next tree
>> ( next-20110831 )
> Sorry I am not able to find it, can you please point me to archives..
Hi Vinod,
Currently you can get linux-next tree at
git://github.com/sfrothwell/linux-next.git
( http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ )
I still got below build error in today's linux-next tree.
CC drivers/dma/imx-sdma.o
drivers/dma/imx-sdma.c:336: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:336: warning: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE'
drivers/dma/imx-sdma.c:336: warning: parameter names (without types)
in function declaration
drivers/dma/imx-sdma.c:343: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:343: warning: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE'
drivers/dma/imx-sdma.c:343: warning: parameter names (without types)
in function declaration
drivers/dma/imx-sdma.c: In function 'sdma_get_firmware':
drivers/dma/imx-sdma.c:1193: error: 'THIS_MODULE' undeclared (first
use in this function)
drivers/dma/imx-sdma.c:1193: error: (Each undeclared identifier is
reported only once
drivers/dma/imx-sdma.c:1193: error: for each function it appears in.)
drivers/dma/imx-sdma.c: At top level:
drivers/dma/imx-sdma.c:1457: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1457: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1457: warning: type defaults to 'int' in
declaration of 'MODULE_AUTHOR'
drivers/dma/imx-sdma.c:1457: warning: function declaration isn't a prototype
drivers/dma/imx-sdma.c:1458: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1458: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1458: warning: type defaults to 'int' in
declaration of 'MODULE_DESCRIPTION'
drivers/dma/imx-sdma.c:1458: warning: function declaration isn't a prototype
drivers/dma/imx-sdma.c:1459: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1459: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1459: warning: type defaults to 'int' in
declaration of 'MODULE_LICENSE'
drivers/dma/imx-sdma.c:1459: warning: function declaration isn't a prototype
make[2]: *** [drivers/dma/imx-sdma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2
Regards,
Axel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h
2011-09-20 13:22 ` Axel Lin
@ 2011-09-20 16:42 ` Vinod Koul
2011-09-20 23:50 ` Axel Lin
0 siblings, 1 reply; 9+ messages in thread
From: Vinod Koul @ 2011-09-20 16:42 UTC (permalink / raw)
To: axel.lin; +Cc: linux-kernel, Sascha Hauer, Dan Williams
On Tue, 2011-09-20 at 21:22 +0800, Axel Lin wrote:
> 2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
> > On Mon, 2011-09-05 at 21:32 +0800, Axel Lin wrote:
> >> 2011/9/5 Vinod Koul <vinod.koul@linux.intel.com>:
> >> > On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
> >> >> Add missing include of linux/module.h to fix build error.
> >> > I don't see this build error in my tree (based on rc4), In which config
> >> > is this seen?
> >> The patch is against linux-next tree.
> >> I got the build error by "make imx_v4_v5_defconfig" on linux-next tree
> >> ( next-20110831 )
> > Sorry I am not able to find it, can you please point me to archives..
> Hi Vinod,
> Currently you can get linux-next tree at
> git://github.com/sfrothwell/linux-next.git
> ( http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ )
>
> I still got below build error in today's linux-next tree.
> CC drivers/dma/imx-sdma.o
> drivers/dma/imx-sdma.c:336: warning: data definition has no type or
> storage class
> drivers/dma/imx-sdma.c:336: warning: type defaults to 'int' in
> declaration of 'MODULE_DEVICE_TABLE'
> drivers/dma/imx-sdma.c:336: warning: parameter names (without types)
> in function declaration
> drivers/dma/imx-sdma.c:343: warning: data definition has no type or
> storage class
> drivers/dma/imx-sdma.c:343: warning: type defaults to 'int' in
> declaration of 'MODULE_DEVICE_TABLE'
> drivers/dma/imx-sdma.c:343: warning: parameter names (without types)
> in function declaration
> drivers/dma/imx-sdma.c: In function 'sdma_get_firmware':
> drivers/dma/imx-sdma.c:1193: error: 'THIS_MODULE' undeclared (first
> use in this function)
> drivers/dma/imx-sdma.c:1193: error: (Each undeclared identifier is
> reported only once
> drivers/dma/imx-sdma.c:1193: error: for each function it appears in.)
> drivers/dma/imx-sdma.c: At top level:
> drivers/dma/imx-sdma.c:1457: error: expected declaration specifiers or
> '...' before string constant
> drivers/dma/imx-sdma.c:1457: warning: data definition has no type or
> storage class
> drivers/dma/imx-sdma.c:1457: warning: type defaults to 'int' in
> declaration of 'MODULE_AUTHOR'
> drivers/dma/imx-sdma.c:1457: warning: function declaration isn't a prototype
> drivers/dma/imx-sdma.c:1458: error: expected declaration specifiers or
> '...' before string constant
> drivers/dma/imx-sdma.c:1458: warning: data definition has no type or
> storage class
> drivers/dma/imx-sdma.c:1458: warning: type defaults to 'int' in
> declaration of 'MODULE_DESCRIPTION'
> drivers/dma/imx-sdma.c:1458: warning: function declaration isn't a prototype
> drivers/dma/imx-sdma.c:1459: error: expected declaration specifiers or
> '...' before string constant
> drivers/dma/imx-sdma.c:1459: warning: data definition has no type or
> storage class
> drivers/dma/imx-sdma.c:1459: warning: type defaults to 'int' in
> declaration of 'MODULE_LICENSE'
> drivers/dma/imx-sdma.c:1459: warning: function declaration isn't a prototype
> make[2]: *** [drivers/dma/imx-sdma.o] Error 1
> make[1]: *** [drivers/dma] Error 2
> make: *** [drivers] Error 2
>
Can you pls send me your .config?
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-09-21 6:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-30 7:08 [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h Axel Lin
2011-09-02 8:21 ` Wolfram Sang
2011-09-05 13:21 ` Vinod Koul
2011-09-05 13:32 ` Axel Lin
2011-09-05 14:36 ` Vinod Koul
2011-09-20 13:22 ` Axel Lin
2011-09-20 16:42 ` Vinod Koul
2011-09-20 23:50 ` Axel Lin
2011-09-21 6:09 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox