Re: [PATCH 01/32 RESEND] nohz: Drop useless call in tick_nohz_start_idle()

Peter Zijlstra
2011-08-29T14:23:54Z

On Mon, 2011-08-15 at 17:51 +0200, Frederic Weisbecker wrote:
> The call to update_ts_time_stats() there is useless. All
> we need is to save the idle entry_time.
>
>
Would have been clearer if you just said the call was a NOP. The whole
second sentence distracts and confuses as its irrelevant to the change
at hand.

If you want to expand you can explain that its a NOP because
update_ts_time_stats() requires either ts->idle_active and/or
@last_update_time and our callsite has neither.

Although this assumes its never called when ts->idle_active is already
set, is this so (likely)? Do we want a WARN_ON_ONCE() testing that
assumption?