Re: [PATCH 15/32] nohz/cpuset: Restart tick when switching to idle task

Frederic Weisbecker
2011-08-30T15:04:38Z

On Mon, Aug 29, 2011 at 05:43:40PM +0200, Peter Zijlstra wrote:
> On Mon, 2011-08-15 at 17:52 +0200, Frederic Weisbecker wrote:
> > Ideally if we are in adaptive nohz mode and we switch to the
> > the idle task, we shouldn't restart the tick since it's going
> > to stop the tick soon anyway.
> >
> > That optimization requires some minor tweaks here and there
> > though, lets handle that later.
>
> You have a knack for confusing changelogs.. so basically you say:
>
> Restart the tick when we switch to idle.
>
> Now all that needs is an explanation of why..

In the end we don't want to restart the tick when we switch to idle.
But to support that I'll need to tweak various things on idle time
accounting, otherwise the [cpu] time spent in idle is going to be
accounted as system time.

That's definetly headed to be temporary.

> Also, please drop the whole cpuset_nohz_ stuff, this really isn't about
> cpusets, cpusets simly provide the interface, the functionality lives in
> the tick_nohz_ namespace.

Agreed this sucks.